Fix custom criteria membership checks#659
Open
Kkkakania wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make custom criteria that match variables in the current object appear in
obj.cf.keys(). BecauseCFAccessor.__contains__delegates tokeys(), membership checks such as"salt" in ds.cfnow agree with successfulds.cf["salt"]lookups.Custom vocabulary entries with no match are intentionally omitted, preserving the documented meaning of
keys()as the set of valid keys for the current object.Closes #375.
Closes #531.
Tests
keys()andin.PYTHONPATH=. ../cf-xarray-127/.venv/bin/python -m pytest cf_xarray/tests -q(284 passed, 1 skipped)uvx pre-commit run --files cf_xarray/accessor.py cf_xarray/tests/test_accessor.pyAI disclosure: this change was AI-assisted. I reproduced the failure before the implementation, reviewed the final diff, and ran the full local test suite and pre-commit hooks.