Drop For You cards whose quote, reply, or retweet text matches muted keywords - #96
Open
Pitchfork-and-Torch wants to merge 3 commits into
Open
Drop For You cards whose quote, reply, or retweet text matches muted keywords#96Pitchfork-and-Torch wants to merge 3 commits into
Pitchfork-and-Torch wants to merge 3 commits into
Conversation
ViewerMutedKeywordFilter only tokenized candidate.tweet_text. Following already matches quoted_tweet_text and ancestor_texts. Clone that matcher and hydrate quoted text on the Phoenix path so a quote of a muted-keyword post is dropped.
QuotedPostTextHydrator only fetched quoted_tweet_id. Thunder already sets reply ancestors on For You, and ViewerMutedKeywordFilter now matches ancestor_texts. Fill those texts from TES without expanding the ancestor chain (gap expansion stays Following-only).
QuotedPostTextHydrator fetched quote and ancestor texts but not retweeted_tweet_id. Native RTs often have empty tweet_text, so a retweet of a muted-keyword post still served. Fetch the original text and match it on For You and Following.
Pitchfork-and-Torch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
ViewerMutedKeywordFilter on Phoenix For You only tokenized candidate.tweet_text. Quotes, replies, and native retweets of muted-keyword posts still served. Native RTs often have empty tweet_text; the original lives on retweeted_tweet_id.
Following already matched quoted_tweet_text and ancestor_texts. It did not match retweet original text either.
This is not mute-on-quote author id (PR 23). Not mute-on-retweet author id (PR 9). Not VF dual-role merge (PR 55 / 90). Not conversation-gap VF ancestors (PR 97).
Fix
Clone the Following matcher and add retweeted_tweet_text on For You and Following. Wire QuotedPostTextHydrator after QuoteHydrator on Phoenix. That hydrator fills quoted_tweet_text, ancestor_texts, and retweeted_tweet_text from TES. It does not expand the ancestor chain.
Proof
Tests