Skip to content

Compute cold-start boost target after MoE suppression #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teddytennant wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

Compute cold-start boost target after MoE suppression #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion home-mixer/scorers/author_cold_start.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ impl AuthorColdStart {
let arm = params.arm;

let mut effective = apply_moe_ranking_policy(arm, candidates, &corpus, scores);
if let Some(target) = cold_start_target(&params, scores) {
if let Some(target) = cold_start_target(&params, &effective) {
effective = apply_cold_start(&params, candidates, &effective, &corpus, target);
}
effective
Expand Down Expand Up @@ -697,6 +697,27 @@ rust_home_mixer:
assert_eq!(result, vec![10.0, 40.0, 30.0, 20.0]);
}

#[test]
fn cold_start_target_skips_scores_zeroed_by_moe_policy() {
let author_cold_start = cold_start_with_arms(vec![], vec![]);
let candidates = vec![
cold_start_candidate(1, minutes(10), 3),
moe_candidate(2, minutes(10), 3),
cold_start_candidate(3, minutes(10), 5000),
cold_start_candidate(4, minutes(10), 5000),
cold_start_candidate(5, minutes(10), 5000),
];

let mut query = codivert_query(false, false);
let mut results = query.params.0.expect("params set");
results.override_fs("rust_home_mixer_cold_start_slot_min".to_string(), "2");
results.override_fs("rust_home_mixer_cold_start_slot_max".to_string(), "3");
query.params = results.into();

let result = author_cold_start.apply(&query, &candidates, &[10.0, 100.0, 90.0, 80.0, 70.0]);
assert_eq!(result, vec![70.0, 0.0, 90.0, 80.0, 70.0]);
}

#[test]
fn ts_top_k_zero_falls_back_to_argmax_score() {
let author_cold_start = cold_start_with_arms(vec![1, 2], vec![]);
Expand Down