Honor account country when applying geo media and legal takedown rules - #113
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Honor account country when applying geo media and legal takedown rules#113Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
DropTweetsWithGeoRestrictedMediaRule calls media_restricted_in_viewer_country. That helper reads only request country_code and treats a missing value as xx (worldwide). ViewerPredicates.country() already prefers account_country_code, then request country.
A US-account viewer with no request country is dropped from US allow-listed media on TimelineHomeRecommendations. Legal/local takedown helpers had the same request-only hole.
This is not safety-label applicable_countries (PR 110). Media geo lists and takedown reasons are a different object.
Fix
Resolve viewer country as account_country_code, then country_code, then xx for media. Legal/local takedown uses the same account-then-request pair. Missing both still drops allow-listed media (existing unknown-country case).
Proof
Tests