Stop applying user-scoped safety labels to unlisted viewers - #112
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Stop applying user-scoped safety labels to unlisted viewers#112Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Tweet safety labels carry applicable_users on the proto (perspectival / holdback lists). SafetyLabelMap::from_proto_label_types keeps only the type key. Drop rules call has_safety_label, which is type presence only.
A DNA or civic label meant for viewer 42 therefore Drops viewer 999 on TimelineHomeRecommendations. The client proto_to_safety_label path already keeps applicable_users. The live filter map did not.
This is not country scope (PR 110) and not expiry (PR 106). Empty applicable_users stays everyone.
Fix
Keep per-type user lists on SafetyLabelMap. TweetPredicates::has_safety_label uses applies(label, viewer_id). Empty or missing scope is everyone. A scoped label does not apply when the viewer is missing or unlisted.
Proof
Tests