Drop replies whose conversation ancestors blocked the viewer - #111
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Drop replies whose conversation ancestors blocked the viewer#111Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
AuthorSocialgraphFilter drops on author_blocks_viewer. FollowingBlockedByHydrator only asked quoted_user_id and retweeted_user_id. BlockedByHydrator only asked author_id.
Conversation modules render ancestor tweets from ancestor_users (parent plus root). PR 101 is viewer mute/block of those ids (filter-only, no RPC). The reverse edge was missing: an ancestor who blocked the viewer never reached check_blocked_by, so author_blocks_viewer stayed false and the reply still served.
This is not mute-on-ancestor (PR 101), not native Following author_id (PR 108), and not Phoenix retweet original (PR 100).
Fix
Include ancestor_users in check_blocked_by. Set author_blocks_viewer if any ancestor blocked the viewer (Following also keeps the retweeted_user_id edge; Phoenix keeps the primary author_id edge).
Proof
Tests