Drop Following posts whose author blocked the viewer - #108
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Drop Following posts whose author blocked the viewer#108Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
FollowingBlockedByHydrator asked socialgraph whether quoted_user_id or retweeted_user_id blocked the viewer. It never sent candidate.author_id. AuthorSocialgraphFilter then drops on author_blocks_viewer (unwrap_or false).
A native Following post from an author who blocked the viewer still served: author_blocks_viewer was written from retweeted_user_id only, so a non-retweet was Some(false). VFFilter None is fail-open, but this path is worse: it claims the author did not block the viewer.
Phoenix BlockedByHydrator already checks author_id. PR 100 added retweeted_user_id on For You. This is the Following twin of that missing native-author edge. This is not mute-on-retweet (PR 9) and not quote mute (PR 23).
Fix
Include author_id in check_blocked_by. Set author_blocks_viewer if either the primary author or the original retweeted author blocked the viewer. Keep quoted_author_blocks_viewer on quoted_user_id.
Proof
Tests