Stop conversation-gap expansion from inserting unhydrated grandparents - #102
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Stop conversation-gap expansion from inserting unhydrated grandparents#102Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConversationGapAncestorHydrator splices a skipped grandparent tweet id into candidate.ancestors from the parent's in_reply_to_tweet_id, then VF and convo_marshaller consume that list. It never TES-fetched the spliced id.
Consequences on Following today (and on For You if PR 97 lands the same hydrator):
This PR TES-fetches spliced ids, then hydrates texts, users, and tombstones from the expanded list. CoreData ancestor_users are merged, not wiped (TES miss does not clear parent/root authors). One class, one file. No ranking changes.
This is not PR 97 (Phoenix wiring of the hydrator) and not PR 101 (the mute/block filter).
Proof
Test plan