fix(analytics): make autoTrack's cleanup function actually remove the click listener - #2600
Open
Grit03 wants to merge 1 commit into
Open
fix(analytics): make autoTrack's cleanup function actually remove the click listener#2600Grit03 wants to merge 1 commit into
Grit03 wants to merge 1 commit into
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
autoTrack()returns a cleanup function that is documented as removing the listeners it set up, but the returned function never removes anything.The listener is registered with
capture: truebut removal is attempted with the defaultcapture: false, so no listener matches and nothing is removed.Related spec references
MDN,
removeEventListener()Parameters,DOM Standard,
removeEventListener()method steps:MDN, "Matching event listeners for removal":
So
captureis the only option used for matching, and omitting it meansfalse.passiveis discarded by the "flatten options" step, so it does not need to be passed toremoveEventListener().Manual Testing
Paste into any page's DevTools console (verified on Chrome 151):
Related Issue
No existing issue.