refactor: Rename internal popup mv2Key option to actionType#2249
Merged
refactor: Rename internal popup mv2Key option to actionType#2249
mv2Key option to actionType#2249Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aklinker1
commented
Apr 12, 2026
mv2Key option to actionTypemv2Key option to actionType
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
==========================================
+ Coverage 76.57% 76.63% +0.05%
==========================================
Files 117 117
Lines 3155 3163 +8
Branches 711 711
==========================================
+ Hits 2416 2424 +8
Misses 657 657
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Contributor
|
Thanks for helping make WXT better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds
actionTypeas a properly-named replacement formv2KeyonPopupEntrypointOptions. The oldmv2Keyname was misleading because it also applies to Firefox MV3. Both properties are kept in sync via getter/setter so modules reading or writing either one see the same value.mv2Keyis marked@deprecated.Manual Testing
pnpm --filter wxt vitest run src/core/utils/__tests__/manifest.test.ts— all 83 tests pass.Related Issue
Follow-up from #2200 (comment)