Skip to content

refactor: Rename internal popup mv2Key option to actionType#2249

Merged
aklinker1 merged 3 commits intomainfrom
refactor/popup-action-type-alias
Apr 12, 2026
Merged

refactor: Rename internal popup mv2Key option to actionType#2249
aklinker1 merged 3 commits intomainfrom
refactor/popup-action-type-alias

Conversation

@aklinker1
Copy link
Copy Markdown
Member

Overview

Adds actionType as a properly-named replacement for mv2Key on PopupEntrypointOptions. The old mv2Key name was misleading because it also applies to Firefox MV3. Both properties are kept in sync via getter/setter so modules reading or writing either one see the same value. mv2Key is marked @deprecated.

Manual Testing

pnpm --filter wxt vitest run src/core/utils/__tests__/manifest.test.ts — all 83 tests pass.

Related Issue

Follow-up from #2200 (comment)

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 12, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 00769c5
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69dbc3586892740008e361cf
😎 Deploy Preview https://deploy-preview-2249--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Apr 12, 2026
@aklinker1 aklinker1 changed the title refactor: rename popup mv2Key option to actionType refactor: Rename internal popup mv2Key option to actionType Apr 12, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.63%. Comparing base (09f27a9) to head (00769c5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/wxt/src/core/utils/building/find-entrypoints.ts 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2249      +/-   ##
==========================================
+ Coverage   76.57%   76.63%   +0.05%     
==========================================
  Files         117      117              
  Lines        3155     3163       +8     
  Branches      711      711              
==========================================
+ Hits         2416     2424       +8     
  Misses        657      657              
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 12, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2249

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2249

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2249

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2249

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2249

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2249

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2249

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2249

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2249

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2249

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2249

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2249

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2249

wxt

npm i https://pkg.pr.new/wxt@2249

commit: 00769c5

@aklinker1 aklinker1 merged commit 2a21279 into main Apr 12, 2026
18 checks passed
@aklinker1 aklinker1 deleted the refactor/popup-action-type-alias branch April 12, 2026 16:15
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for helping make WXT better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant