fix: resolve TS build errors in manifest.ts options_ui#2237
fix: resolve TS build errors in manifest.ts options_ui#2237shadoath wants to merge 2 commits intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CI Status NotesThe three checks showing as The Netlify deploy-preview checks (Redirect rules, Header rules, Pages changed) are failing, but this appears to be a fork PR infrastructure issue (missing deploy secrets) rather than anything related to this change. No docs were modified. Once a maintainer approves the CI run, the actual build, test, and lint jobs will execute against the fix. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
+ Coverage 76.24% 76.34% +0.10%
==========================================
Files 115 115
Lines 3094 3095 +1
Branches 685 686 +1
==========================================
+ Hits 2359 2363 +4
+ Misses 653 650 -3
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Default `openInTab` to `false` to satisfy `boolean` (not `boolean | undefined`) - Remove now-unused `@ts-expect-error` since `browser_style` is typed in `@wxt-dev/browser` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ffdf429 to
e5a4d67
Compare
|
@shadoath I though, that's issue, because of missing rebase and i've jump on conclution my commit is necessary. Without this // ignore line it's not possible to pass I'm not merging it for now, i'm waiting for your response. |
Summary
openInTabtofalseto satisfyboolean(notboolean | undefined) onopen_in_tab@ts-expect-errorsincebrowser_styleis now typed in@wxt-dev/browserTest plan
npm run buildpasses without TS errorsoptions_ui.open_in_tabbehaves correctly whenopenInTabis not set (defaults tofalse)🤖 Generated with Claude Code