Skip to content

fix: resolve TS build errors in manifest.ts options_ui#2237

Open
shadoath wants to merge 2 commits intowxt-dev:mainfrom
shadoath:sb/fix-build-errors
Open

fix: resolve TS build errors in manifest.ts options_ui#2237
shadoath wants to merge 2 commits intowxt-dev:mainfrom
shadoath:sb/fix-build-errors

Conversation

@shadoath
Copy link
Copy Markdown

@shadoath shadoath commented Apr 9, 2026

Summary

  • Default openInTab to false to satisfy boolean (not boolean | undefined) on open_in_tab
  • Remove now-unused @ts-expect-error since browser_style is now typed in @wxt-dev/browser

Test plan

  • Verify npm run build passes without TS errors
  • Confirm options_ui.open_in_tab behaves correctly when openInTab is not set (defaults to false)

🤖 Generated with Claude Code

@shadoath shadoath requested a review from aklinker1 as a code owner April 9, 2026 13:30
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit e5a4d67
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69d9023462609900087065c7
😎 Deploy Preview https://deploy-preview-2237--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Apr 9, 2026
@shadoath
Copy link
Copy Markdown
Author

shadoath commented Apr 9, 2026

CI Status Notes

The three checks showing as action_required (Validate, Check PR Title, pkg.pr.new) have not actually run yet — they're waiting on maintainer approval, which is GitHub's standard security gate for fork PRs. No jobs have executed under those workflows.

The Netlify deploy-preview checks (Redirect rules, Header rules, Pages changed) are failing, but this appears to be a fork PR infrastructure issue (missing deploy secrets) rather than anything related to this change. No docs were modified.

Once a maintainer approves the CI run, the actual build, test, and lint jobs will execute against the fix.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 10, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2237

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2237

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2237

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2237

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2237

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2237

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2237

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2237

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2237

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2237

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2237

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2237

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2237

wxt

npm i https://pkg.pr.new/wxt@2237

commit: e5a4d67

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.34%. Comparing base (65c3c7e) to head (e5a4d67).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
+ Coverage   76.24%   76.34%   +0.10%     
==========================================
  Files         115      115              
  Lines        3094     3095       +1     
  Branches      685      686       +1     
==========================================
+ Hits         2359     2363       +4     
+ Misses        653      650       -3     
  Partials       82       82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shadoath and others added 2 commits April 10, 2026 15:59
- Default `openInTab` to `false` to satisfy `boolean` (not `boolean | undefined`)
- Remove now-unused `@ts-expect-error` since `browser_style` is typed in `@wxt-dev/browser`

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@PatrykKuniczak
Copy link
Copy Markdown
Collaborator

@shadoath I though, that's issue, because of missing rebase and i've jump on conclution my commit is necessary.
But indeed after rebase it's still necessary.

Without this // ignore line it's not possible to pass check.

I'm not merging it for now, i'm waiting for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants