Security: Reverse tabnabbing risk from target="_blank" links without rel protections#2230
Open
tuanaiseo wants to merge 1 commit intowxt-dev:mainfrom
Conversation
Multiple templates open external sites in new tabs with `target="_blank"` but without `rel="noopener noreferrer"`. Opened pages can access `window.opener` and potentially navigate the originating extension page. Affected files: App.tsx Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
@tuanaiseo It's even possible to reffer to popup from outer page. Both PRs looks like, vibe hacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multiple templates open external sites in new tabs with
target="_blank"but withoutrel="noopener noreferrer". Opened pages can accesswindow.openerand potentially navigate the originating extension page.Severity:
lowFile:
templates/react/entrypoints/popup/App.tsxSolution
Add
rel="noopener noreferrer"to all external links usingtarget="_blank"across templates and docs components.Changes
templates/react/entrypoints/popup/App.tsx(modified)Testing