fix: add Firefox action manifest typings#2217
Open
VaughnBosu wants to merge 1 commit intowxt-dev:mainfrom
Open
fix: add Firefox action manifest typings#2217VaughnBosu wants to merge 1 commit intowxt-dev:mainfrom
VaughnBosu wants to merge 1 commit intowxt-dev:mainfrom
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2217 +/- ##
==========================================
- Coverage 76.21% 76.17% -0.04%
==========================================
Files 115 115
Lines 3094 3094
Branches 685 685
==========================================
- Hits 2358 2357 -1
- Misses 653 655 +2
+ Partials 83 82 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PatrykKuniczak
approved these changes
Apr 1, 2026
3f45907 to
40d54d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added FirefoxActionManifestOptions interface with browser_style, default_area, and theme_icons, and applied it to action, browser_action, and page_action in UserManifest.
Manual Testing
pnpm test run manifest passes
Added default_area and theme_icons to wxt-demo/wxt.config.ts — no type errors, and the values appeared in the built manifest.json
Related Issue
This PR closes #2096