Add mapping-only structured serialization module - #466
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3992f9425
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function writeSerializedFields(FieldSerializationWriter writer) | ||
| wurstForFields((fieldName, value) -> writer.write(fieldName, value)) | ||
|
|
||
| function readSerializedFields(FieldSerializationReader reader) | ||
| wurstMapFields((fieldName, value) -> value.readSerializedField(reader, fieldName)) |
There was a problem hiding this comment.
When consumers use a compiler predating the canonical #1224 intrinsic names, these wurstForFields/wurstMapFields calls are not lowered, so any class adopting the new module fails to compile. This package explicitly preserves those compiler versions immediately below in SerializableFields by calling the recognized forFields/mapFields aliases; use the same aliases here so the new public module retains that compatibility.
AGENTS.md reference: AGENTS.md:L3-L6
Useful? React with 👍 / 👎.
1 participant
Summary
Verification