Fix Grill failure exit codes - #78
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6cf6f3683
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| if (!setup.quiet) { | ||
| println(line) | ||
| return try { |
There was a problem hiding this comment.
If reading the compiler output or waitFor() throws after pb.start() succeeds—for example, when the calling thread is interrupted—this broad catch returns a failure result without waiting for or terminating the child. The caller then exits Grill with status 1 while the orphaned compiler may continue modifying map or build outputs; retain the Process and destroy it on exceptional paths, or limit this catch to failures that occur before the process starts.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
--quiet.Validation
./gradlew.bat test --tests CMDTests.testCompilerDependentCommandsFailWhenCompilerIsMissingEvenInQuietMode./gradlew.bat test