Skip to content

Add guide for gateway federation#305

Open
ShalkiWenushika wants to merge 3 commits into
wso2:mainfrom
ShalkiWenushika:gw_federation
Open

Add guide for gateway federation#305
ShalkiWenushika wants to merge 3 commits into
wso2:mainfrom
ShalkiWenushika:gw_federation

Conversation

@ShalkiWenushika

Copy link
Copy Markdown
Contributor

Purpose

https://github.com/wso2-enterprise/apim-gtm/issues/460

Checklist

  • Verified that llms.txt (located at en/docs/llms.txt) is updated for AI readiness content.
  • Ensured meaningful alt text for images and that the information contained in an image also appears in text so the relevant info exists in the body of the document.
  • Added or updated frontmatter for the respective pages.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Added a new Gateway Federation documentation guide, “Discover APIs from AWS API Gateway.” It walks through the end-to-end workflow for integrating an AWS API Gateway REST API into WSO2 API Platform gateway federation via a third-party gateway: deploy an AWS REST API to a stage, create IAM credentials, register the third-party gateway in API Platform, run discovery to pull REST API metadata and create API references, validate the discovered APIs in Insights → Compliance, and publish them to the Developer Portal lifecycle so developers can discover and subscribe. The guide also includes an architecture overview, verification checklist, troubleshooting section, and next-step references.

Updated en/mkdocs.yml to add a new “Gateway Federation” section under Guides and link to the new guide (guides/gateway-federation/discover-apis-from-aws-api-gateway.md).

Walkthrough

Adds a new guide for discovering AWS API Gateway REST APIs through API Platform gateway federation. The guide covers AWS setup, IAM credential creation, Third Party Gateway registration, discovery, compliance review, publishing, verification, troubleshooting, and next steps. It also adds a Guides navigation entry for the new page.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The template is present, but most sections are left as placeholders and lack substantive details. Fill in Purpose, Goals, Approach, User stories, Release note, Documentation, and other relevant sections with concrete details; use N/A only where truly applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: adding a gateway federation guide.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 markdownlint-cli2 (0.22.1)
en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md

markdownlint-cli2 wrapper config was not available before execution


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (5)
en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md (5)

34-34: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Specify a language for the fenced code block.

The architecture diagram uses a fenced code block without a language specifier, which triggers markdownlint warning MD040. Add text to satisfy the linter and maintain consistency.

♻️ Proposed fix
-```
+```text
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md` at
line 34, The fenced architecture diagram block is missing a language tag, which
triggers the MD040 markdownlint warning. Update the diagram’s fenced block in
the gateway-federation docs to use a language specifier, using the existing
markdown fence around the diagram content and adding text so it matches the rest
of the document.

84-86: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Vary the phrasing in successive numbered steps.

Steps 3–5 all begin with "Under," which reads repetitively. Consider rewording one step (e.g., "In the Choose an API type section, select...") for smoother flow.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md`
around lines 84 - 86, The numbered setup steps in the gateway federation guide
repeat the same “Under” phrasing, making the sequence feel repetitive. Reword
one of the affected instruction lines in the API selection flow, such as the
step that references API Details or API endpoint type, so the successive steps
in the section read with varied phrasing while preserving the same actions.

20-20: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Hyphenate compound modifier "third-party" when it modifies a noun.

In prose, "third party" should be hyphenated as "third-party" when used attributively before a noun (e.g., "third-party gateway"). This occurs throughout the document. Keep UI labels verbatim (e.g., Third Party Gateway) but adjust running text for correctness.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md` at
line 20, The guide text uses “third party” as an attributive modifier, which
should be hyphenated throughout the prose. Update the running text in this
document to use “third-party” before nouns, including the introductory sentence
in the AWS API Gateway guide and any similar occurrences elsewhere, while
leaving UI labels like “Third Party Gateway” unchanged.

156-180: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Standardize hyphenation and capitalization for "third-party gateway" in prose.

In running text, use "third-party gateway" (hyphenated). Reserve "Third Party Gateway" for exact UI labels. Line 158 has inconsistent capitalization ("Third party gateway" — should be "third-party gateway" or "Third Party Gateway" if it's a proper noun).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md`
around lines 156 - 180, Update the prose in the gateway registration section to
use consistent hyphenation and capitalization for the concept of a third-party
gateway. In the Step 3 heading/body around the gateway setup instructions,
replace running-text uses like “Third party gateway” with “third-party gateway,”
and keep “Third Party Gateway” only when referring to the exact UI tab or button
labels in the API Platform Console. Use the surrounding Step 3 instructions and
the “Add Third Party Gateway” label as the reference points for the wording.

163-163: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Adjust UI label formatting for the tab name.

"Tab" should not be part of the bold UI label unless the tab itself is literally named "Third Party Tab". Use "Select the Third Party tab." or "Select Third Party." to match standard UI writing conventions.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md` at
line 163, The UI label formatting in the AWS API Gateway guide needs to be
corrected so “Tab” is not part of the bolded tab name unless that is the exact
UI label. Update the wording around the “Third Party” tab in the affected doc to
follow the standard convention used elsewhere, such as selecting the **Third
Party** tab, and keep the phrasing consistent with other UI references in the
same guide.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md`:
- Line 118: The numbered procedure has a duplicate step label, so update the
final item in the AWS API Gateway guide sequence to use the next unique number.
Adjust the step text for the Deploy action so the ordering in this list is
consistent, and keep the numbering aligned with the surrounding steps in the
same section.
- Around line 225-236: Step 5 currently jumps straight to Insights > Compliance
even though the user is still on the project overview after discovery. Update
the instructions in the gateway federation guide to first navigate to the
discovered API’s overview page, using the API name or equivalent selection step
in the surrounding flow, before opening Compliance. Keep the compliance check
tied to the API/component context by referencing the discovered API overview
step in this section.

---

Nitpick comments:
In `@en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md`:
- Line 34: The fenced architecture diagram block is missing a language tag,
which triggers the MD040 markdownlint warning. Update the diagram’s fenced block
in the gateway-federation docs to use a language specifier, using the existing
markdown fence around the diagram content and adding text so it matches the rest
of the document.
- Around line 84-86: The numbered setup steps in the gateway federation guide
repeat the same “Under” phrasing, making the sequence feel repetitive. Reword
one of the affected instruction lines in the API selection flow, such as the
step that references API Details or API endpoint type, so the successive steps
in the section read with varied phrasing while preserving the same actions.
- Line 20: The guide text uses “third party” as an attributive modifier, which
should be hyphenated throughout the prose. Update the running text in this
document to use “third-party” before nouns, including the introductory sentence
in the AWS API Gateway guide and any similar occurrences elsewhere, while
leaving UI labels like “Third Party Gateway” unchanged.
- Around line 156-180: Update the prose in the gateway registration section to
use consistent hyphenation and capitalization for the concept of a third-party
gateway. In the Step 3 heading/body around the gateway setup instructions,
replace running-text uses like “Third party gateway” with “third-party gateway,”
and keep “Third Party Gateway” only when referring to the exact UI tab or button
labels in the API Platform Console. Use the surrounding Step 3 instructions and
the “Add Third Party Gateway” label as the reference points for the wording.
- Line 163: The UI label formatting in the AWS API Gateway guide needs to be
corrected so “Tab” is not part of the bolded tab name unless that is the exact
UI label. Update the wording around the “Third Party” tab in the affected doc to
follow the standard convention used elsewhere, such as selecting the **Third
Party** tab, and keep the phrasing consistent with other UI references in the
same guide.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e958ba35-8aed-43f4-8e4a-961d5a20a94b

📥 Commits

Reviewing files that changed from the base of the PR and between 6f16f54 and 429fc3c.

⛔ Files ignored due to path filters (8)
  • en/docs/assets/img/guides/gateway-federation/add-third-party-gateway.png is excluded by !**/*.png
  • en/docs/assets/img/guides/gateway-federation/compliance-dashboard.png is excluded by !**/*.png
  • en/docs/assets/img/guides/gateway-federation/create-api.png is excluded by !**/*.png
  • en/docs/assets/img/guides/gateway-federation/created-api-list.png is excluded by !**/*.png
  • en/docs/assets/img/guides/gateway-federation/discover-apis-from-gateways.png is excluded by !**/*.png
  • en/docs/assets/img/guides/gateway-federation/discover-apis.png is excluded by !**/*.png
  • en/docs/assets/img/guides/gateway-federation/publish-to-devportal.png is excluded by !**/*.png
  • en/docs/assets/img/guides/gateway-federation/third-party-gateway-listing.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md
  • en/mkdocs.yml

Comment thread en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md`:
- Line 20: Update the wording in the AWS API Gateway discovery guide so the
compound modifier uses “third-party” consistently wherever it modifies “gateway”
or “gateways.” Fix the occurrences in the introductory paragraph and the later
reference near the end of the document, keeping the phrasing otherwise
unchanged.
- Line 20: The guide uses the unhyphenated compound modifier “third party
gateway” in the introduction and later reference, which should be written as
“third-party gateway” when modifying “gateway.” Update both occurrences in the
AWS API Gateway discovery guide so the wording is consistent and grammatically
correct, using the same terminology wherever the gateway is described.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e5ceda9a-10df-48ff-924f-d27e7bce46ef

📥 Commits

Reviewing files that changed from the base of the PR and between 2e07fb4 and 19e1797.

📒 Files selected for processing (1)
  • en/docs/guides/gateway-federation/discover-apis-from-aws-api-gateway.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant