Document MTLS Authenticator policy for API proxy#185
Conversation
📝 WalkthroughSummaryThis PR introduces comprehensive documentation for the MTLS Authenticator policy, a resource-level mediation policy for API proxies. The changes include a new policy guide, updates to the policies reference list, and navigation configuration. ChangesDocumentation Files Added/Modified:
ImpactThese documentation additions enable developers to understand and implement the MTLS Authenticator policy for their API proxies, providing both reference information and practical implementation guidance. Files Changed: 3 WalkthroughThis pull request adds documentation for the MTLS Authenticator inbuilt mediation policy. The changes include adding a new policy entry to the policies reference list, creating a comprehensive guide with step-by-step instructions for enabling mutual TLS authentication between clients and the API gateway, and updating the navigation configuration to include the new guide. The documentation covers certificate generation, policy configuration, deployment, and client invocation procedures. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
en/docs/develop-api-proxy/policy/secure-client-gateway-communication-with-mtls.md (1)
11-13: Add security guidance for private key protection.The OpenSSL command uses the
-nodesflag, which creates an unencrypted private key file. While this simplifies development and testing, it poses a security risk if the key file is not properly protected.Consider adding a note to warn users that the generated private key is unencrypted and should be stored securely with appropriate file permissions (e.g.,
chmod 600 mykey.pem), or guide them to use encrypted keys for production environments.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@en/docs/develop-api-proxy/policy/secure-client-gateway-communication-with-mtls.md` around lines 11 - 13, The OpenSSL command shown (openssl req -x509 -newkey rsa:2048 -keyout mykey.pem -out mycert.pem -days 365 -nodes) generates an unencrypted private key due to the -nodes flag; update the doc around that snippet to warn users the private key is unencrypted, instruct them to protect the key with strict file permissions (e.g., chmod 600 mykey.pem) for local/dev use, and add guidance to use encrypted keys in production by omitting -nodes and supplying a passphrase or using a secure key management solution.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@en/docs/develop-api-proxy/policy/policies.md`:
- Line 30: The link to the mTLS guide in the "MTLS Authenticator" paragraph is
using an incorrect relative path
(`../policy/secure-client-gateway-communication-with-mtls.md`) — update the link
in en/docs/develop-api-proxy/policy/policies.md (the "MTLS Authenticator" line)
to point to the sibling page using a correct relative path, e.g.
`./secure-client-gateway-communication-with-mtls/` or
`secure-client-gateway-communication-with-mtls` (omit the ../policy/ prefix and
the .md extension to match MkDocs use_directory_urls conventions).
In
`@en/docs/develop-api-proxy/policy/secure-client-gateway-communication-with-mtls.md`:
- Line 64: The relative link is too deep; replace the href string
"../../../administer/settings/configure-a-custom-domain-for-your-organization/"
with the correct two-level-up path
"../../administer/settings/configure-a-custom-domain-for-your-organization/" in
the markdown line that begins "To configure a custom domain for an API Proxy..."
so the link correctly points from the develop-api-proxy/policy document to the
administer/settings page.
- Line 21: Replace the unhyphenated phrase "Resource wise policies" with the
hyphenated form "Resource-wise policies" in both occurrences within this
document (the instances at the top of the file including the line currently
reading 'Go to Develop -> Policies and click "Resource wise policies" in the
left panel' and the second occurrence referenced in the review), ensuring the
exact quoted label text is updated so it matches other docs like "Resource-wise
Guardrails" and "Resource-level Policies".
---
Nitpick comments:
In
`@en/docs/develop-api-proxy/policy/secure-client-gateway-communication-with-mtls.md`:
- Around line 11-13: The OpenSSL command shown (openssl req -x509 -newkey
rsa:2048 -keyout mykey.pem -out mycert.pem -days 365 -nodes) generates an
unencrypted private key due to the -nodes flag; update the doc around that
snippet to warn users the private key is unencrypted, instruct them to protect
the key with strict file permissions (e.g., chmod 600 mykey.pem) for local/dev
use, and add guidance to use encrypted keys in production by omitting -nodes and
supplying a passphrase or using a secure key management solution.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 576a77fe-4ba1-4d8e-9553-779bdcc2819d
⛔ Files ignored due to path filters (1)
en/docs/assets/img/develop-api-proxy/policy/mtls-auth-policy.pngis excluded by!**/*.png
📒 Files selected for processing (3)
en/docs/develop-api-proxy/policy/policies.mden/docs/develop-api-proxy/policy/secure-client-gateway-communication-with-mtls.mden/mkdocs.yml
Purpose
This PR introduces documentation with regards to the MTLS Authenticator Policy