[APICP] Add extension contact for host binaries - #3183
Merged
Conversation
lasanthaS
requested review from
AnuGayan,
Arshardh,
CrowleyRajapakse,
HeshanSudarshana,
HiranyaKavishani,
Induwara04,
Krishanx92,
PasanT9,
Piumal1999,
RakhithaRR,
Tharsanan1,
Thushani-Jayasekera,
VirajSalaka,
ashera96,
chamilaadhi,
dushaniw,
hisanhunais,
malinthaprasan,
pubudu538,
renuka-fernando,
senthuran16,
tgtshanika,
tharikaGitHub,
tharindu1st and
thivindu
as code owners
August 8, 2026 03:10
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe API Control Plane now supports host-injected cloud extensions in routes and navigation. Its Makefiles and release workflow support testing, version management, multi-architecture image publishing, release tagging, and automated snapshot-version pull requests. Development instructions now include the Platform API process. ChangesFrontend extensions
Release automation
Estimated code review effort: 4 (Complex) | ~45 minutes Mergeability Score: ⚪ Minimal · up to This change has no actionable merge-blocking risk in the supplied evidence and is ready to merge after normal checks and review. Sequence Diagram(s)Frontend extension flowsequenceDiagram
participant Browser
participant main
participant App
participant AppRoutes
participant useNavigationItems
Browser->>main: Start application
main->>App: Pass loaded cloud extensions
App->>AppRoutes: Generate protected extension routes
App->>useNavigationItems: Build extension navigation items
useNavigationItems-->>Browser: Render filtered navigation
Release flowsequenceDiagram
participant Maintainer
participant GitHubActions
participant Makefile
participant GHCR
participant Git
Maintainer->>GitHubActions: Provide release versions
GitHubActions->>Makefile: Run tests and image publishing
Makefile->>GHCR: Push multi-architecture images
GitHubActions->>Git: Push release tag and snapshot update
GitHubActions-->>Maintainer: Create version-bump pull request
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@portals/api-control-plane/README.md`:
- Around line 35-38: Update the Terminal 1 instructions in the README to use the
repository root as the starting directory, replacing the relative navigation
with cd platform-api while preserving the existing setup and run commands.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 50851b13-097d-4904-9007-697bdf75af29
📒 Files selected for processing (1)
portals/api-control-plane/README.md
AnuGayan
previously approved these changes
Aug 8, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@portals/api-control-plane/bff/app/app_test.go`:
- Around line 62-75: Close every HTTP response body created by the listed test
requests after the final assertion or JSON decoding. Update the requests in
portals/api-control-plane/bff/app/app_test.go (lines 62-75) and all listed
response-handling sites in
portals/api-control-plane/bff/internal/server/options_test.go (lines 51-55,
76-80, 94-98, 118-122, 147-162, and 206-235); preserve the existing assertions
and use the wrapped-route JSON decode path as the established pattern.
In `@portals/api-control-plane/bff/internal/server/server.go`:
- Around line 224-234: Update New(), routes(), and the ExtraRoutes option
handling in portals/api-control-plane/bff/internal/server/server.go (224-234,
263-264, 269) and portals/api-control-plane/bff/internal/server/options.go
(29-52) to validate route patterns, nil handlers, wrapper/override results, and
duplicate registrations—including ExtraRoutes conflicts with default routes and
the "/" route—before calling http.ServeMux.Handle. Return descriptive errors
from New() for every invalid option instead of allowing ServeMux panics; ensure
each affected site performs the requested validation or propagates the
validation error.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 172a1f45-6287-4a19-b019-8c0a1db36097
📒 Files selected for processing (8)
portals/api-control-plane/README.mdportals/api-control-plane/bff/app/app.goportals/api-control-plane/bff/app/app_test.goportals/api-control-plane/bff/internal/server/middleware.goportals/api-control-plane/bff/internal/server/options.goportals/api-control-plane/bff/internal/server/options_test.goportals/api-control-plane/bff/internal/server/server.goportals/api-control-plane/bff/internal/session/context.go
🚧 Files skipped from review as they are similar to previous changes (1)
- portals/api-control-plane/README.md
lasanthaS
changed the title
Contributor
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
.github/workflows/apip-api-control-plane-release.yml (1)
42-46: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove the deprecated Buildx installation mode.
install: trueuses the deprecateddocker buildx installbehavior. Remove this input and verify that the configured builder remains selected for the later build command.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/apip-api-control-plane-release.yml around lines 42 - 46, Remove the install input from the Docker Buildx setup step, leaving the configured docker-container driver unchanged. Verify that the subsequent build command explicitly uses or otherwise retains the setup action’s selected builder without relying on deprecated docker buildx install behavior.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/apip-api-control-plane-release.yml:
- Around line 25-29: Update the “Set version” step before invoking version-set
to validate VERSION and reject values ending in “-SNAPSHOT”; fail the workflow
with a clear error and do not run version-set when the validation fails.
- Around line 48-49: Add a dependency-installation step before “Run tests” in
the workflow, executing npm ci with working-directory set to
portals/api-control-plane. Keep the existing make test-api-control-plane step
unchanged and ensure the install runs first.
- Around line 22-23: Pin all six GitHub Actions in
.github/workflows/apip-api-control-plane-release.yml to immutable commit SHAs
matching their intended release tags: update the actions at lines 22-23, 31-32,
36-37, 42-43, 51-52, and 94-96, including the Checkout code step, without
changing their action versions or workflow behavior.
In `@portals/api-control-plane/src/main.tsx`:
- Around line 32-36: Update the startup flow around the dynamic import of
./cloud to catch rejected imports, report the error, and still call root.render
with App using an empty cloudExtensions list. Preserve the existing
cloudExtensions rendering path when the import succeeds; handle the failure
before rendering so ErrorBoundary is not relied on for this bootstrap error.
In `@portals/api-control-plane/src/navigation/useNavigationItems.ts`:
- Line 65: Update the route matcher in the navigation item configuration so the
route suffix matches only as a complete path segment, preventing prefixes such
as reports from matching reports-archive while still matching the route itself
and its descendant paths.
---
Nitpick comments:
In @.github/workflows/apip-api-control-plane-release.yml:
- Around line 42-46: Remove the install input from the Docker Buildx setup step,
leaving the configured docker-container driver unchanged. Verify that the
subsequent build command explicitly uses or otherwise retains the setup action’s
selected builder without relying on deprecated docker buildx install behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 446fc5fa-d4c6-4591-a970-621d0b23451c
📒 Files selected for processing (10)
.github/workflows/apip-api-control-plane-release.ymlMakefileportals/api-control-plane/Makefileportals/api-control-plane/src/App.tsxportals/api-control-plane/src/cloud/index.tsportals/api-control-plane/src/extensions.tsxportals/api-control-plane/src/index.tsportals/api-control-plane/src/main.tsxportals/api-control-plane/src/navigation/useNavigationItems.tsportals/api-control-plane/src/routes/AppRoutes.tsx
Induwara04
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Security checks