Repository navigation
test(faustwp): ignore WPGraphQL deprecations in mutation tests - #2734
Open
josephfusco wants to merge 1 commit into
Open
josephfusco wants to merge 1 commit into
josephfusco wants to merge 1 commit into
Conversation
WPGraphQL 2.28.0 calls SplObjectStorage::contains(), deprecated in PHP 8.5. PHPUnit turned that into an exception mid-request, which also left WPGraphQL's request flag set and broke the URL replacement tests that ran afterwards.
josephfusco
marked this pull request as ready for review
November 16, 2026 17:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every open PR fails the WordPress 7.1 (PHP 8.5) job since WPGraphQL 2.28.0 shipped; the URL replacement failures are a side effect of the aborted mutation request, and Faust's own deprecations still fail the tests.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with diagnosing the PHP 8.5 test failures and scoping the fix to WPGraphQL.