Repository navigation
fix(cli): start Next.js on Windows with Node 22+ - #2733
Draft
josephfusco wants to merge 3 commits into
Draft
josephfusco wants to merge 3 commits into
josephfusco wants to merge 3 commits into
Conversation
Run the Next.js CLI script with the current Node binary instead of spawning next.cmd, which Node rejects with EINVAL since the CVE-2024-27980 fix. Exit non-zero with an error when Next.js can't be found or fails to start, instead of exiting 0 silently. Fixes #2725
Move the spawn into runNext so the exit-code handling behind #2725 can be tested.
Next.js has always published bin as an object.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2725
The Windows path hasn't been run on a Windows machine yet; macOS was checked by running the built CLI against an installed Next.js and with Next.js missing.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with diagnosing the Windows spawn failure and writing the fix and tests.