Windows: Add hardening when renaming Phar during update#6297
Windows: Add hardening when renaming Phar during update#6297swissspidy wants to merge 3 commits intomainfrom
Conversation
|
Hello! 👋 Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project. Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation. Here are some useful Composer commands to get you started:
To run a single Behat test, you can use the following command: # Run all tests in a single file
composer behat features/some-feature.feature
# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123You can find a list of all available Behat steps in our handbook. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Code Review
This pull request introduces Windows-specific logic for updating the WP-CLI PHAR file, utilizing a backup file during the rename process to avoid potential file locking issues. Feedback was provided to improve the robustness of the realpath() call, as it can return false and result in an empty string when cast; a suggestion was made to fall back to the original path and to ensure support for tilde expansion in home-relative paths.
No description provided.