Behat steps: support file names containing spaces - #342
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughQuoted file and cache paths containing spaces are now normalized by Behat steps, with scenarios covering creation, existence, and exact content assertions. ChangesQuoted path handling
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant BehatScenario
participant GivenStepDefinitions
participant ThenStepDefinitions
participant Filesystem
BehatScenario->>GivenStepDefinitions: provide quoted file or cache path
GivenStepDefinitions->>Filesystem: create file at normalized path
BehatScenario->>ThenStepDefinitions: assert quoted path
ThenStepDefinitions->>Filesystem: verify existence and contents
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 PHPStan (2.2.6)PHPStan was skipped because the config uses disallowed Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary by CodeRabbit