Add Behat scenarios for wp cli update --stable / --nightly PHP version checks - #1093
Open
swissspidy wants to merge 1 commit into
Open
Add Behat scenarios for wp cli update --stable / --nightly PHP version checks#1093swissspidy wants to merge 1 commit into
wp cli update --stable / --nightly PHP version checks#1093swissspidy wants to merge 1 commit into
Conversation
…annel manifest requires_php
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds CLI feature scenarios verifying that stable and nightly updates fail when their manifests require an unavailable PHP version. ChangesUpdate gating validation
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accompanying test suite update for wp-cli/wp-cli#6362, which gates
wp cli update --stableandwp cli update --nightlyon the minimum PHP version specified in the build channel manifest files (wp-cli.manifest.jsonandwp-cli-nightly.manifest.json).These scenarios ensure that WP-CLI Phar self-updates abort early with a descriptive error message when a user's PHP version does not meet the manifest requirement, preventing broken Phar updates during PHP version floor bumps.
Changes
Added two new Behat scenarios to
features/cli.feature:Prevent stable update when PHP version requirement is not met: Stubs an HTTP response forwp-cli.manifest.jsonwith"requires_php": "99.0.0"and verifies that{PHAR_PATH} cli update --stable --yesexits with status 1 and reports the requirement.Prevent nightly update when PHP version requirement is not met: Stubs an HTTP response forwp-cli-nightly.manifest.jsonwith"requires_php": "99.0.0"and verifies that{PHAR_PATH} cli update --nightly --yesexits with status 1 and reports the requirement.Summary by CodeRabbit