-
Notifications
You must be signed in to change notification settings - Fork 19
Add --no-interaction flag to prevent Git/SSH prompts in package commands #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
21
commits into
main
Choose a base branch
from
copilot/add-non-interactive-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+103
−3
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3edda0e
Initial plan
Copilot 415fb60
Add --no-interaction option to package commands
Copilot f8ca62d
Add documentation for update() parameters and putenv() usage
Copilot e68d8d6
Change flag to 'interaction' with default true, keep --no-interaction…
Copilot 60df40b
Fix synopsis
swissspidy 249e76e
Fix test to use real package name from package index
Copilot 0a6dc7f
Merge branch 'main' into copilot/add-non-interactive-option
swissspidy a6df039
Update src/Package_Command.php
swissspidy 27ab934
Update src/Package_Command.php
swissspidy 1b84407
Update src/Package_Command.php
swissspidy 3e26c9a
Update src/Package_Command.php
swissspidy 10cb4e0
Merge branch 'main' into copilot/add-non-interactive-option
swissspidy 891c476
Update src/Package_Command.php
swissspidy eab45f7
Merge branch 'main' into copilot/add-non-interactive-option
swissspidy 68d4741
Update src/Package_Command.php
swissspidy 559907d
Update src/Package_Command.php
swissspidy 6776563
Merge branch 'main' into copilot/add-non-interactive-option
swissspidy 2edb889
Fix phpdoc
swissspidy 386d5e5
Add newline
swissspidy 5ac3863
Improve tests to actually verify environment variables are set
Copilot 0b70a31
Replace env var tests with actual Git/SSH interaction tests
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -194,3 +194,22 @@ Feature: Update WP-CLI packages | |
| Error: Package 'non-existent/package' is not installed. | ||
| """ | ||
| And the return code should be 1 | ||
|
|
||
| @github-api | ||
| Scenario: Update packages with --no-interaction completes without prompting | ||
| Given an empty directory | ||
|
|
||
| # Install a real package | ||
| When I run `wp package install danielbachhuber/wp-cli-reset-post-date-command` | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO: use a wp-cli owned package |
||
| Then STDOUT should contain: | ||
| """ | ||
| Success: Package installed. | ||
| """ | ||
|
|
||
| # Update with --no-interaction should complete without hanging | ||
| When I run `wp package update --no-interaction` | ||
| Then STDOUT should contain: | ||
| """ | ||
| Packages updated. | ||
| """ | ||
| And STDERR should be empty | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: replace this with an actual private repo in the wp-cli org.