Skip to content

Extract translatable strings from Blade component prop bindings#474

Merged
swissspidy merged 3 commits intowp-cli:mainfrom
retlehs:blade-component-props
Feb 15, 2026
Merged

Extract translatable strings from Blade component prop bindings#474
swissspidy merged 3 commits intowp-cli:mainfrom
retlehs:blade-component-props

Conversation

@retlehs
Copy link
Contributor

@retlehs retlehs commented Feb 13, 2026

Fixes an issue where translation functions passed as bound props on Blade components aren't picked up by make-pot.

Given a template like:

<x-alert :message="__('Page not found.', 'my-theme')" />

<x-no-results
    :title="__('Nothing here', 'my-theme')"
    :subtitle="esc_html__('Try searching instead', 'my-theme')"
/>

None of these strings end up in the .pot file. The workaround is to pull them into variables first, which is clunky:

@php($message = __('Page not found.', 'my-theme'))
<x-alert :message="$message" />

@retlehs retlehs requested a review from a team as a code owner February 13, 2026 18:58
@github-actions
Copy link

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@gemini-code-assist
Copy link

Summary of Changes

Hello @retlehs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where make-pot failed to detect translatable strings embedded within Blade component prop bindings. By introducing a dedicated mechanism to extract these PHP expressions, the change significantly enhances the internationalization capabilities for Blade templates, ensuring all translatable content is properly captured for localization.

Highlights

  • Improved i18n for Blade Components: Translatable strings within Blade component prop bindings (e.g., :message="__('Page not found.')") are now correctly identified and extracted by make-pot, resolving a previous limitation.
  • New Expression Extraction Logic: A new static method, extractComponentPropExpressions, was introduced to parse Blade component tags and extract PHP expressions from their bound attributes.
  • Enhanced String Processing: The fromStringMultiple method now incorporates the extracted PHP expressions from component props, ensuring they are included in the overall string scanning process for translation functions.
Changelog
  • src/BladeGettextExtractor.php
    • Added extractComponentPropExpressions method to parse Blade component attributes and extract bound PHP expressions.
    • Modified fromStringMultiple to append extracted component prop expressions to the PHP string for translation scanning.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

gemini-code-assist[bot]

This comment was marked as resolved.

This comment was marked as resolved.

@swissspidy swissspidy merged commit 7df61b3 into wp-cli:main Feb 15, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments