Skip to content

Fix incorrect TIS class-period time mapping used by ICS and reminders #15

Description

@Stevvven777

The TIS calendar/reminder implementation uses an incorrect class-period mapping from period 5 onward and accepts nonexistent periods 12-13.

Verified against the SUSTech “上课节次时间查询” PDF:

  • P1 08:00-08:50
  • P2 09:00-09:50
  • P3 10:20-11:10
  • P4 11:20-12:10
  • P5 14:00-14:50
  • P6 15:00-15:50
  • P7 16:20-17:10
  • P8 17:20-18:10
  • P9 19:00-19:50
  • P10 20:00-20:50
  • P11 21:00-21:50

Current code starts P5 at 13:30, P7 at 15:30, P9 at 18:00, and defines P12/P13. This shifts generated ICS events and current/next-class reminders.

Acceptance criteria:

  • Update the canonical mapping to P1-P11 above.
  • Reject unsupported P12/P13 values where time conversion is required.
  • Update regression tests for ICS generation and live period lookup.
  • Keep timetable planning ranges aligned with the supported TIS periods.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions