Skip to content

Fix failing CI - #75

Merged
zkfriendly merged 4 commits into
mainfrom
fs/fix-ci
Sep 22, 2026
Merged

zkfriendly merged 4 commits into
mainfrom
fs/fix-ci

Conversation

@frozenspider

@frozenspider frozenspider commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

A follow-up to #74 (comment), resolves #63

  1. large_shape() was too large to use in a full e2e test suite as it took way too much time and memory - on my machine it was killed due to OOM after running more than 7 minutes, which isn't viable at all.
    To work around that, part of the Instance code has been moved to HonestClaim, and large_shape() now only tests a subset of e2e flow.

  2. Even then, ubuntu-latest build takes 55 minutes. Turns out, optimization level matters a lot: e.g. malformed_virtual_proofs_are_rejected locally takes 45 second in unoptimized + debuginfo and just 1 second in optimized + debuginfo configuration.
    Here, I decided to enable CARGO_PROFILE_TEST_OPT_LEVEL: 3 for CI only, bringing ubuntu-latest build + test time to much more bearable 10 minutes fresh/8.5 minutes cached.
    However, doing this locally would trigger long rebuilds often and interfere with debugging, so instead I've added opt-level = 3 to dependencies that benefited the most from it. This adds just a few seconds build time but makes malformed_virtual_proofs_are_rejected complete in 20 sec (2x faster) on my machine.

  3. Additionally, added -C target-feature=+aes on aarch64 architectures to speed up tests even further

@frozenspider frozenspider changed the title [WIP] Fix failing CI Fix failing CI Sep 22, 2026
@frozenspider
frozenspider marked this pull request as ready for review September 22, 2026 19:52

@zkfriendly zkfriendly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the fix

@zkfriendly
zkfriendly merged commit cff5e35 into main Sep 22, 2026
3 checks passed
@zkfriendly
zkfriendly deleted the fs/fix-ci branch September 22, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken test an_honest_proof_verifies_on_every_shape_the_profile_admits

2 participants