GKR: Second optimisation set - #60
Merged
Merged
Conversation
xrvdg
marked this pull request as draft
September 14, 2026 12:58
xrvdg
added this pull request to stack #56
September 14, 2026 12:58
zkfriendly
self-requested a review
September 16, 2026 06:04
xrvdg
marked this pull request as ready for review
September 16, 2026 14:28
shreyas-londhe
force-pushed
the
xr/opt-v2
branch
from
September 17, 2026 02:33
4359618 to
154c23c
Compare
zkfriendly
requested changes
Sep 17, 2026
zkfriendly
left a comment
zkfriendly
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR; all looked correct. Left some minor comments. The CI is also failing due to some clippy issues, would be nice to address that too.
…e h==1 last round
…dd alloc_storage helper
zkfriendly
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second pass at the GKR prover's round loop with the goal to only have pure computations and memory access. Some of the changes are just for cleaner profiles.
Auxiliary
single_threaded.patch is regenerated at the repo root against the new reduce loop, and a test helper's RNG trait bound is corrected from RngCore to Rng.