Repository navigation
fix(session): Reject non-user access tokens in session cookies - #573
Merged
Merged
Conversation
Session#authenticate now requires the verified access token to carry sid and auth_time, a sub_profile that is absent or user, and no sub_type, so other token types signed by the same environment key do not authenticate a session. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
Original prompt from madison.packer
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Devin Review🟢 Devin Review found nothing to fix · View findings |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
 [Medium impact] The PR appears safe to merge; no new actionable issues were found. Summary
Reviews (2) · Last reviewed commit: "test(session): Cover expired non-user to..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
@greptileai review |
Contributor
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session#authenticate(andSessionManager#authenticate, which delegates to it) verified the sealed access token's signature, expiry and issuer, but not that it was a user session access token. Other token types signed by the same environment key were accepted as a session.After
decode_jwt, it now returnsINVALID_JWTunless the new privateuser_access_token?(decoded)check passes:This matches
hasRequiredAccessTokenClaimsin workos-node.sub_profileis optional on user access tokens, so a missing claim is still accepted. The check runs before theinclude_expiredbranch, so non-user tokens are also rejected there.Tests: new cases seal tokens with
sub_profile: ai_agent,sub_type: authkit, and noauth_time, and expectINVALID_JWT. There is also a positive case forsub_profile: user. The 3 rejection cases fail without thesession.rbchange.make_jwtnow defaultsauth_time, as real user access tokens include it.Link to Devin session: https://app.devin.ai/sessions/7e123fc2545a49c282b043a4abd58f70
Open in Devin Desktop: https://app.devin.ai/desktop/session/7e123fc2545a49c282b043a4abd58f70?variant=devin
Requested by: @m0tzy