fix: unblock lockfile action release - #11
Merged
Merged
Conversation
Contributor
Author
|
marktran
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automatic
v1release after PR #10 failed withGitHub-signed release commit tree differs from the staged tree, leaving the lockfile repair action unpublished. The newscripts/scrub-lockfile.shwas executable in the staged package, but GitHub'screateCommitOnBranchfile additions cannot specify an executable mode for a new file.This removes the helper's unnecessary executable bit (
100755→100644). The controller, CI, and tests already invoke it throughbash, so its behavior does not change. No publisher logic, signature verification, exact-tree checks, token permissions, or release workflow is changed.The previous publisher mock returned the desired tree hash directly, hiding this mismatch. The regression now constructs an actual Git tree from the mutation payload, preserving existing file modes and assigning
100644to new files against a five-file pre-scrub release fixture. The fixed package passes. Reintroducing the executable bit produces the same release error and verifies that neither discovery ref moves and the temporary staging branch is cleaned up. The packaged controller/normalizer tests also run successfully with the non-executable helper.From the repository root, with Bash, Node.js 24+, Git, jq, and standard command-line utilities, no credentials or dependency installation are needed:
These checks passed locally. The new publisher regression failed with the original file mode before the fix. All 49 Node tests, the existing shell suites, ShellCheck, shfmt, and workflow linting passed as well.
After this merges and main CI passes, the existing release workflow should publish the new action-only commit. This PR does not publish a release or manually move any refs; that live verification remains necessary after merge.
Failed release run:
https://github.com/workos/setup-socket-firewall/actions/runs/34853295286
Related work:
#10
https://linear.app/workos/issue/HELP-723