Optimize minId query and improve test coverage#21
Merged
Conversation
MIN() performs a full scan on large tables and can time out. Switching to ORDER BY + LIMIT 1 leverages existing indexes on the primary key and time columns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Cover timestamptz cast, null result when all rows are excluded, and string (ULID) primary keys with time filtering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mthadley
commented
Feb 19, 2026
Collaborator
Author
There was a problem hiding this comment.
We are starting to adopt mise elsewhere so just sneaking this in (since otherwise I no longer had a global node installed when in this repo).
stefanmb
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ORDER BY ... LIMIT 1instead ofMIN()in theminIdquery, which allows Postgres to use an index scan instead of a full table scanactions/setup-nodetojdx/mise-actionfor Node.js version management in CIminIdtime filter options: timestamptz cast, null result when all rows are excluded, and string (ULID) primary keys with time filteringTest plan
npm test -- run🤖 Generated with Claude Code