Skip to content

fix(pipes): Correct connected account ownership - #179

Open
dandorman wants to merge 1 commit into
mainfrom
fix/pipes-organization-connected-accounts
Open

dandorman wants to merge 1 commit into
mainfrom
fix/pipes-organization-connected-accounts

Conversation

@dandorman

Copy link
Copy Markdown

Summary

  • Mount OrganizationsDataProviders onto Pipes, alongside UserManagementDataProviders, so Pipes-scoped generation includes all five organization endpoints.
  • Map organization data providers and ConnectedAccount* release metadata to pipes, and classify connected-account files as Pipes rather than WorkOS Connect.
  • Add regression coverage for real-policy mounts, release metadata classification, and Pipes-scoped Node generation placing organization methods, options, and shared models beneath src/pipes without cross-service imports.
  • Verified npm run build:policy and npm test: all 136 tests pass with no skips.

Organization endpoints were omitted from Pipes-scoped generation, leaving
shared model imports under an ungenerated service. Connected account
release notes also incorrectly identified the product as WorkOS Connect.
@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the ownership changes consistently applied and covered by focused regression tests.

Summary

This PR corrects Pipes ownership for organization-scoped data-provider operations and connected-account release metadata.

  • Mounts OrganizationsDataProviders onto the generated Pipes service.
  • Classifies organization data-provider services, connected-account symbols, and corresponding SDK files under the pipes release scope.
  • Adds regression coverage for policy resolution, release metadata, generated methods, shared models, and cross-service import isolation.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  ODP[OrganizationsDataProviders] -->|mount rule| P[Pipes]
  UDP[UserManagementDataProviders] -->|existing mount rule| P
  CA[ConnectedAccount symbols and files] -->|release classification| PS[pipes release scope]
  P --> G[src/pipes generated SDK surface]
  PS --> C[Pipes changelog metadata]
Loading

Reviews (1) · Last reviewed commit: "fix(pipes): Correct connected account ow..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant