-
Notifications
You must be signed in to change notification settings - Fork 10
Use Ruby 3.4.9 and re-bundle #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Changes from all commits
5256777
19d019a
a9ec5d0
b3e85cf
1cef861
c7c1fa0
cab3b32
afe31c6
d43af2d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,9 @@ | ||
| #!/bin/bash | ||
|
|
||
| export IMAGE_ID="xcode-26.1.1" | ||
| export IMAGE_ID="xcode-26.6" | ||
| export CI_TOOLKIT="automattic/a8c-ci-toolkit#5.7.0" | ||
| export DOCKER_PLUGIN="docker#v5.13.0" | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| export RUBY_VERSION="$(cat "$SCRIPT_DIR/../.ruby-version")" | ||
| RUBY_VERSION="$(cat "$SCRIPT_DIR/../.ruby-version")" | ||
| export RUBY_VERSION | ||
| export DOCKER_RUBY_IMAGE="public.ecr.aws/docker/library/ruby:$RUBY_VERSION" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1 @@ | ||
| 3.2.2 | ||
|
|
||
| 3.4.9 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -438,11 +438,9 @@ PLATFORMS | |
| DEPENDENCIES | ||
| activesupport (~> 8.1) | ||
| buildkite-test_collector (~> 2.3) | ||
| bundler (~> 2.0) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this came from the old gem generator. But we don't need to define an explicit dependency on Bundler. As far as I know, we don't use any of its API directly. |
||
| codecov | ||
| danger-dangermattic (~> 1.0) | ||
| faraday (~> 1.10, >= 1.10.6) | ||
| fastlane (~> 2.210) | ||
| fastlane-plugin-wpmreleasetoolkit! | ||
| pry (~> 0.12.2) | ||
| rmagick (~> 5.3) | ||
|
|
@@ -455,4 +453,4 @@ DEPENDENCIES | |
| yard | ||
|
|
||
| BUNDLED WITH | ||
| 2.6.8 | ||
| 4.0.17 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,18 +42,4 @@ Gem::Specification.new do |spec| | |
|
|
||
| # `google-cloud-storage` is required by fastlane, but we pin it in case it's not in the future | ||
| spec.add_dependency 'google-cloud-storage', '~> 1.31' | ||
|
|
||
| # Only needed for specs (Time.use_zone, String#to_time, Hash#slice!) | ||
| spec.add_development_dependency 'activesupport', '~> 8.1' | ||
| spec.add_development_dependency 'bundler', '~> 2.0' | ||
| # Use at least Fastlane 2.210.0 to ensure compatibility with the Xcode 14 toolchain | ||
| # See https://github.com/fastlane/fastlane/releases/tag/2.210.0 | ||
| spec.add_development_dependency 'fastlane', '~> 2.210' | ||
| spec.add_development_dependency 'pry', '~> 0.12.2' | ||
| spec.add_development_dependency 'rmagick', '~> 5.3' | ||
| spec.add_development_dependency 'rspec', '~> 3.8' | ||
| spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1' | ||
| spec.add_development_dependency 'rubocop', '~> 1.65' | ||
| spec.add_development_dependency 'rubocop-rspec', '3.0' | ||
| spec.add_development_dependency 'simplecov', '~> 0.16.1' | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The docs are somewhat ambiguous:
Happy to revert if we find this confusing. In which case, though, we should also move the remaining gems from |
||
| end | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ShellCheck told me about this.