Show a loading indicator while a theme activates - #25993
Open
crazytonyli wants to merge 4 commits into
Open
Conversation
Activating from the theme grid gave no feedback because the spinner was only attached to the preview screen's Activate bar button, which does not exist in that flow. The browser now tracks the activating theme and the grid cell replaces its "..." button with a spinner while the request runs. The state lives in the view controller so it survives cell reuse and reloads, and a second activation is ignored while one is in flight.
The spinner replacing the Activate bar button was forced to white, which is invisible on the preview's light navigation bar. Use the default color instead.
It only popped the theme browser, which the back button already does.
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 34375 | |
| Version | PR #25993 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 9075e20 | |
| Installation URL | 0thrqe5lqgs1g |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 34375 | |
| Version | PR #25993 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 9075e20 | |
| Installation URL | 0bonuahjqlc68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes (kinda) https://linear.app/a8c/issue/CMM-2366. The "Manage site" action only dismisses the theme view controller, which I think is unnecessary. So, I removed it in this PR.
The PR fixes another issue: On the theme browser, tap the "..." button on a theme, tap "Activate", and wait. Nothing changes on screen until the "Theme Activated" alert shows up. Activating from the theme preview screen has the same problem, because the spinner replacing the "Activate" bar button is white on a white navigation bar.
The grid cell now replaces its "..." button with a spinner while the theme is being activated, and the preview bar button spinner uses the default color.
theme-activation.MP4