Custom Posts: Show "Post updated" notice by crazytonyli · Pull Request #25576 · wordpress-mobile/WordPress-iOS

crazytonyli · 2026-05-21T21:16:08Z

Description

Mirror the existing UX: show notice after post is saved/published.

The first commit is code-format changes and can be ignored.

wpmobilebot · 2026-05-21T21:30:21Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`32654`
	Version	`PR #25576`
	Bundle ID	`com.jetpack.alpha`
	Commit	`a198936`
	Installation URL	55rl9m36mqth8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-05-21T21:30:39Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`32654`
	Version	`PR #25576`
	Bundle ID	`org.wordpress.alpha`
	Commit	`a198936`
	Installation URL	2vnjfjrcns2q8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

jkmassel

Left a comment, but also publishPost notifies now but what about moveToDraft, trashPost, and deletePost?

jkmassel · 2026-06-10T17:39:48Z

            editorService: editorService,
            blog: blog,
            from: vc,
            completion: { _ in }


Does this need a similar body to the one in showPublishingSheet?

jkmassel · 2026-06-10T17:45:46Z

    }
 }
+
+private enum Strings {


Is this a duplicate of the ViewModel strings?

WDYT about extracting them into a higher-level shared CustomPostNotice string set?

jkmassel · 2026-06-10T17:50:57Z

@@ -251,6 +255,12 @@ private extension CustomPostEditorViewController {
    func save(publish: Bool) async {


I think we only ever pass false here, so do we need this param? (this will cause a breaking change in callers)

Suggested change

func save(publish: Bool) async {

func save() async {

jkmassel · 2026-06-10T17:54:24Z

+                    let postTitle = editorService.post?.title?.raw
+                    let subtitle = (postTitle?.isEmpty == false) ? postTitle : nil
+                    Notice(title: Strings.CustomPostNotice.postPublished, message: subtitle, feedbackType: .success)
+                        .post()


We repeat this pattern a bunch – I wonder if we could extract it to a helper? Could be the enum you use to consolidate the strings?

crazytonyli · 2026-06-10T23:10:43Z

what about moveToDraft, trashPost, and deletePost

I didn't touch those because the existing Posts list does not show a notice on these actions.

Post a Notice toast on every HTTP write to the site from the Custom Post editor (save draft, update, publish) and from the standalone settings sheet reached from the Custom Posts list. The notice's title reflects the action: "Draft saved" only on the first save of a brand-new post, "Post updated" for any save of an existing post, and "Post published" via the publishing sheet. The post title is the notice's subtitle (omitted when empty). Localized strings live in a shared CustomPostNotice enum.

Move the success notice into PublishPostViewController.show(editorService:blog:from:completion:) so both the custom post editor and the Custom Posts list show it after publishing through the sheet. Consolidate the duplicated notice strings into a shared CustomPostNoticeStrings type.

…r.save The method is only ever called to persist a draft or update, so drop the always-false publish parameter and the dead publish-only branches.

jkmassel · 2026-06-17T18:24:38Z

-        publishVC.onCompletion = completion
+        publishVC.onCompletion = { result in
+            if case .published = result {
+                let postTitle = editorService.post?.title?.raw


Cosmetic: a whitespace-only title slips past .isEmpty, so the toast renders a blank second line. Trimming here (matching titleForDisplay) avoids it:

Suggested change

let postTitle = editorService.post?.title?.raw

let postTitle = editorService.post?.title?.raw?.trimmingCharacters(in: .whitespacesAndNewlines)

jkmassel · 2026-06-17T18:24:39Z

            )
            let viewModel = CustomPostSettingsViewModel(editorService: editorService, blog: blog, isStandalone: true)
+            viewModel.onEditorPostSaved = { [editorService] in
+                let postTitle = editorService.post?.title?.raw


Same whitespace nit as the publishing sheet — trim so a blank title doesn't show an empty subtitle line:

Suggested change

let postTitle = editorService.post?.title?.raw

let postTitle = editorService.post?.title?.raw?.trimmingCharacters(in: .whitespacesAndNewlines)

jkmassel · 2026-06-17T18:24:39Z

-                completion()
-            }
+            let title = isNewPost ? CustomPostNoticeStrings.draftSaved : CustomPostNoticeStrings.postUpdated
+            let subtitle = data.title.isEmpty ? nil : data.title


Same whitespace nit — data.title isn't trimmed before the .isEmpty check:

Suggested change

let subtitle = data.title.isEmpty ? nil : data.title

let trimmedTitle = data.title.trimmingCharacters(in: .whitespacesAndNewlines)

let subtitle = trimmedTitle.isEmpty ? nil : trimmedTitle

jkmassel · 2026-06-17T18:24:39Z

+/// Localized titles for the success notices emitted when a custom post is
+/// persisted to the server. Shared between the editor, the publishing sheet,
+/// and the Custom Posts list.
+enum CustomPostNoticeStrings {


Optional follow-on to the three whitespace nits: the trim + empty→nil logic now repeats at all three notice sites. Since this enum is already the shared home, a small helper would keep it in one place:

static func subtitle(from rawTitle: String?) -> String? { let trimmed = rawTitle?.trimmingCharacters(in: .whitespacesAndNewlines) return trimmed?.isEmpty == false ? trimmed : nil }

Then each call site becomes CustomPostNoticeStrings.subtitle(from: …). Take it or leave it — the inline trims work fine too; this just avoids triplicating the fix.

jkmassel

Sorry – I meant to note this whitespace thing earlier. I tried to make it easy to apply :)

wpmobilebot · 2026-06-18T03:27:50Z

Version 27.0 has now entered code-freeze, so the milestone of this PR has been updated to 27.1.

crazytonyli added this to the 27.0 milestone May 21, 2026

crazytonyli requested a review from jkmassel May 21, 2026 21:16

crazytonyli added the Posts + Pages label May 21, 2026

crazytonyli force-pushed the task/custom-posts-show-notice branch from 6c9a5a3 to caae1e1 Compare May 25, 2026 10:12

jkmassel requested changes Jun 10, 2026

View reviewed changes

crazytonyli force-pushed the task/custom-posts-show-notice branch from caae1e1 to e7d646d Compare June 15, 2026 23:52

crazytonyli added 3 commits June 16, 2026 12:15

Reformat PublishPostViewController with swift-format

693ccb9

Remove the unused publish argument from CustomPostEditorViewControlle…

a198936

…r.save The method is only ever called to persist a draft or update, so drop the always-false publish parameter and the dead publish-only branches.

crazytonyli requested a review from jkmassel June 16, 2026 00:33

jkmassel reviewed Jun 17, 2026

View reviewed changes

jkmassel requested changes Jun 17, 2026

View reviewed changes

wpmobilebot modified the milestones: 27.0, 27.1 Jun 18, 2026

		@@ -251,6 +255,12 @@ private extension CustomPostEditorViewController {
		func save(publish: Bool) async {

	let postTitle = editorService.post?.title?.raw
	let postTitle = editorService.post?.title?.raw?.trimmingCharacters(in: .whitespacesAndNewlines)

	let subtitle = data.title.isEmpty ? nil : data.title
	let trimmedTitle = data.title.trimmingCharacters(in: .whitespacesAndNewlines)
	let subtitle = trimmedTitle.isEmpty ? nil : trimmedTitle

Conversation

crazytonyli commented May 21, 2026

Description

Uh oh!

wpmobilebot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkmassel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crazytonyli commented Jun 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkmassel left a comment

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wpmobilebot commented May 21, 2026 •

edited

Loading

wpmobilebot commented May 21, 2026 •

edited

Loading