Add Devices item to Top List #25176
Open
Add Devices item to Top List #25176
+1,188
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
kean
force-pushed
the
task/devices-card
branch
from
e1220f4 to
e760e17
Compare
kean
force-pushed
the
task/devices-card
branch
from
e760e17 to
340cb53
Compare
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30646 | |
| Version | PR #25176 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 4bdaa48 | |
| Installation URL | 4svimrl93lih8 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30646 | |
| Version | PR #25176 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 4bdaa48 | |
| Installation URL | 6vjb6lql68u50 |
Contributor
Author
|
There is a bit of an issue with parsing production data - fixing. |
kean
force-pushed
the
task/devices-card
branch
2 times, most recently
from
5dc411c to
5e4d54f
Compare
kean
force-pushed
the
task/devices-card
branch
from
5e4d54f to
4bdaa48
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CMM-599: Add Devices breakdown (Premium+).
The feature and the implementation are pretty straightforward. It simply uses the existing infrastructure to add new TopListItemType, parse data using
StatsTimeIntervalData, use SwiftUI Charts to render a pie chart – nothing fancy.One issue I encounter was a limitation of how data measurements are models in JetpackStats. I documented it in code and in CMM-1168: Switch to Double to represent data points. I plan to address it separately.
##Screenshots
I used the existing
TopListCarddesign and structure to represent "Screen Time". It's different form the web, but I think it works. I didn't want to add an ad-hoc card just for this one use-case just yet.