CMM-2174: Move background-start work off the main thread - #23285
Open
nbradbury wants to merge 9 commits into
Open
CMM-2174: Move background-start work off the main thread#23285nbradbury wants to merge 9 commits into
nbradbury wants to merge 9 commits into
Conversation
Play Console names the main-thread frames behind the Sentry "Background ANR" bucket: WordPressDB open, WorkManager init, the Gravatar Quick Editor startup initializer (AndroidKeyStore/Tink in a ContentProvider), the BOOT_COMPLETED receiver, and analytics metadata DB reads. - Remove the Gravatar androidx.startup initializer from the manifest and initialize it on demand from MeFragment - Open WordPressDB lazily (synchronized getter) and warm it on IO - Initialize WorkManager on demand via Configuration.Provider; enqueue the periodic upload work off the main thread - Run NotificationsPendingDraftsReceiver work on a background thread with goAsync() - Move refreshMetadata, install/upgrade tracks and the notification state check into one ordered IO coroutine; move the media-sanitize site lookup into its worker thread - Drop the dead fatal_db_error launch check and its string
Collaborator
Generated by 🚫 Danger |
Contributor
Project manifest changes for WordPressThe following changes in the --- ./build/reports/diff_manifest/WordPress/jetpackRelease/base_manifest.txt 2026-09-03 22:06:27.333777227 +0000
+++ ./build/reports/diff_manifest/WordPress/jetpackRelease/head_manifest.txt 2026-09-03 22:06:45.330945053 +0000
@@ -1316,9 +1316,6 @@
android:authorities="com.jetpack.android.androidx-startup"
android:exported="false" >
<meta-data
- android:name="com.gravatar.quickeditor.initializer.QuickEditorContainerInitializer"
- android:value="androidx.startup" />
- <meta-data
android:name="androidx.emoji2.text.EmojiCompatInitializer"
android:value="androidx.startup" />
<meta-data
@@ -1401,16 +1398,6 @@
android:name="org.wordpress.android.posttypes.CptHierarchicalPostListActivity"
android:exported="false"
android:theme="@style/Cpt.NoActionBar" />
- <activity
- android:name="com.gravatar.quickeditor.ui.GravatarQuickEditorActivity"
- android:exported="true"
- android:launchMode="singleTask"
- android:theme="@style/GravatarQETheme.Transparent" />
- <activity
- android:name="com.gravatar.quickeditor.ui.oauth.GravatarOAuthActivity"
- android:exported="true"
- android:launchMode="singleTask"
- android:theme="@style/GravatarQETheme.Transparent" />
<provider
android:name="com.gravatar.quickeditor.QuickEditorFileProvider"Go to https://buildkite.com/automattic/wordpress-android/builds/28518/canvas?sid=01a0694c-e1de-4e72-9ebe-733882310219, click on the |
Contributor
Project manifest changes for WordPressThe following changes in the --- ./build/reports/diff_manifest/WordPress/wordpressRelease/base_manifest.txt 2026-09-03 22:06:25.674183293 +0000
+++ ./build/reports/diff_manifest/WordPress/wordpressRelease/head_manifest.txt 2026-09-03 22:06:44.327034249 +0000
@@ -1291,9 +1291,6 @@
android:authorities="org.wordpress.android.androidx-startup"
android:exported="false" >
<meta-data
- android:name="com.gravatar.quickeditor.initializer.QuickEditorContainerInitializer"
- android:value="androidx.startup" />
- <meta-data
android:name="androidx.emoji2.text.EmojiCompatInitializer"
android:value="androidx.startup" />
<meta-data
@@ -1376,16 +1373,6 @@
android:name="org.wordpress.android.posttypes.CptHierarchicalPostListActivity"
android:exported="false"
android:theme="@style/Cpt.NoActionBar" />
- <activity
- android:name="com.gravatar.quickeditor.ui.GravatarQuickEditorActivity"
- android:exported="true"
- android:launchMode="singleTask"
- android:theme="@style/GravatarQETheme.Transparent" />
- <activity
- android:name="com.gravatar.quickeditor.ui.oauth.GravatarOAuthActivity"
- android:exported="true"
- android:launchMode="singleTask"
- android:theme="@style/GravatarQETheme.Transparent" />
<provider
android:name="com.gravatar.quickeditor.QuickEditorFileProvider"Go to https://buildkite.com/automattic/wordpress-android/builds/28518/canvas?sid=01a0694c-e1dd-4d3d-a4fc-e2f40aad9106, click on the |
Contributor
|
|
Contributor
|
|
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
- Make WordPress.wpDB a lazy property; collapse the duplicate catch and remember a failure so a broken database isn't deleted on every access - Add a launchIo helper in AppInitializer so every background step is guarded the same way; use it for the media-sanitize step too - Keep install/upgrade tracking on the main thread so it precedes APPLICATION_OPENED; only the metadata refresh moves to IO - Catch Exception rather than Throwable in the boot receiver - Move the Gravatar initializer lookup into GravatarQuickEditorInitializer, warm it from MeFragment off the main thread, and initialize it before any of the library's exported activities is created
Lint's UnsafeProtectedBroadcastReceiver only looks at onReceive itself, so read the action there and pass it to the background handler.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #23285 +/- ##
==========================================
- Coverage 37.93% 37.93% -0.01%
==========================================
Files 2352 2353 +1
Lines 128925 128935 +10
Branches 17940 17937 -3
==========================================
+ Hits 48907 48908 +1
- Misses 76012 76021 +9
Partials 4006 4006 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Restore trunk's synchronous analytics init; moving the metadata refresh off main kept surfacing attribution gaps for background-started processes, so that stays as-is until the tracker persists the username - MeFragment: replace the warm-up/guard pair with one Deferred started in onCreate; retry the init once on tap if the warm-up failed; skip showing if the view is no longer started - Catch LinkageError in GravatarQuickEditorInitializer; add an explicit keep rule so the by-name lookup doesn't depend on library rules - Remove the two unused exported Gravatar activities from the manifest instead of initializing the container for them at runtime - LocalNotificationScheduler resolves WorkManager lazily so injecting it no longer initializes WorkManager on the main thread - launchIo uses the injected IO dispatcher; drop the WordPressDB recreate flag; keep the pending-drafts receiver's behaviour unchanged
…m-2174-background-anr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
We've had a long-standing issue with various ANRs at start-up caused by initializing processes on the main thread. This PR attempts to resolve most of the ANRs by moving these processes off the main thread:
BOOT_COMPLETEDDescription
Fixes CMM-2174 (Sentry JETPACK-ANDROID-PB9, "Background ANR").
That Sentry issue is an ANRv2 bucket built from the main thread's idle-looper stack, so it can't point at a cause. Play Console can: for 3 Aug–1 Sep the named main-thread frames on background process starts (WorkManager
SystemJobService,BOOT_COMPLETED, FCM) wereWordPressDB.<init>,AppInitializer.initWorkManager, the Gravatar Quick Editor'sandroidx.startupinitializer (AndroidKeyStore + Tink self-test inside a ContentProvider, beforeApplication.onCreate), and the pending-drafts receiver.MeFragment. The class is Kotlin-internal, hence the lookup by name;startup-runtime's consumer rules keep allInitializers under R8.WordPressDB:WordPress.wpDBis now a lazy synchronized getter (same delete-and-recreate fallback), warmed onDispatchers.IO. The deadisWpDBInitializedcheck inWPLaunchActivityand itsfatal_db_errorstring are removed.Configuration.ProvideronWordPress; the periodic upload enqueue runs off main.InitializationRulejoins that job soUploadWorkerTestcan't race the test WorkManager swap.NotificationsPendingDraftsReceiver:goAsync()+ background thread.refreshMetadata, install/upgrade tracks and the notification-state check run in one ordered IO coroutine (Tracks attributes events from state the refresh sets). The media-sanitize site lookup moves into its worker thread.Every new
appScope.launchis try/caught because that scope has a plainJob.Success metric is the Play ANR buckets above, not the Sentry issue, which will reopen regardless. The
SystemJobServicebucket should shrink, not vanish: WorkManager still initializes on main inside its own service on job-triggered starts.Not addressed here: Sentry init, fluxc
AccountStoreconstructor DB read, fluxc Volley queue creation,EncryptedLoggingconstruction.Testing instructions
Gravatar editor:
Note: If you get an "Oops" message here, it's unrelated to this PR - it's a known issue that has been reported to the Gravatar team.
Legacy DB:
Boot receiver:
adb logcat -s WordPress-NOTIFSshows "entering Pending Drafts Receiver from BOOT_COMPLETED"WorkManager: