Skip to content

chore(release): 0.18.1#556

Merged
crazytonyli merged 1 commit into
trunkfrom
jkmassel/ios-release-versioning-fix
Jul 19, 2026
Merged

chore(release): 0.18.1#556
crazytonyli merged 1 commit into
trunkfrom
jkmassel/ios-release-versioning-fix

Conversation

@jkmassel

Copy link
Copy Markdown
Contributor

What?

Bumps 0.18.00.18.1 to cut a patch release that ships #551 — version bump only, no other changes.

Why?

v0.18.0 predates #551, which stamps CFBundleShortVersionString and MinimumOSVersion into the GutenbergKitResources.framework Info.plist. Without those keys, apps embedding GutenbergKit fail to upload to TestFlight (altool 90057 / 90360). The fix is on trunk but unreleased, so no SPM consumer can pin a tag that contains it. This is the bump that lets us tag v0.18.1.

How?

npm --no-git-tag-version version patch + npm run generate-version — four files, version fields only:

  • package.json / package-lock.json0.18.1
  • ios/Sources/GutenbergKit/Sources/GutenbergKitVersion.swiftversion = "0.18.1" — compiled into the GutenbergKit library from source (even in .release mode), so it has to be committed at the tagged commit
  • android/.../GutenbergKitVersion.ktVERSION = "0.18.1"

No rebuilt web bundle, unlike the 0.18.0 bump. The CI Build XCFramework step downloads a freshly-built dist/ and copy-dist-ios overwrites the committed Gutenberg/ bundle before packaging — "ship the just-built dist rather than whatever was committed at HEAD" (Makefile) — and build_xcframework.sh stamps the framework version from package.json. So the committed bundle isn't load-bearing for the tag, and it's byte-identical to v0.18.0 regardless (#551 only touched build_xcframework.sh). Trunk stays resourcesMode = .local; its committed bundle keeps reporting 0.18.0 in JS error metadata until the next full build — cosmetic, trunk-only, invisible to tag consumers.

Testing Instructions

Publish is the manual Buildkite flow (docs/releases.md), pinned to this PR's merge commit:

  • Merge to trunk
  • Trigger automattic/gutenbergkit → Branch trunk, Commit = merge SHA, NEW_VERSION=v0.18.1
  • Validate Swift release passes (no pre-existing tag/Release)
  • v0.18.1 tag + GitHub Release published, XCFramework on CDN
  • Downstream app embedding v0.18.1 uploads to TestFlight cleanly (verifies the 90057/90360 regression is gone)

Related: #551

@github-actions github-actions Bot added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jul 18, 2026
@jkmassel
jkmassel requested review from crazytonyli and dcalhoun and removed request for crazytonyli July 18, 2026 23:48
@wpmobilebot

Copy link
Copy Markdown

XCFramework Build

This PR's XCFramework is available for testing. Add the following to your Package.swift:

.package(url: "https://github.com/wordpress-mobile/GutenbergKit", branch: "pr-build/556")

Built from fb2e06f

@crazytonyli

Copy link
Copy Markdown
Contributor

I'll merge this PR and release the version.

@crazytonyli
crazytonyli merged commit 0e8694f into trunk Jul 19, 2026
23 checks passed
@crazytonyli
crazytonyli deleted the jkmassel/ios-release-versioning-fix branch July 19, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants