Repository navigation
Render desc as a template again - #334
Merged
Merged
Conversation
#330 made desc literal text, so a brace in a file name no longer raised. That changed what every 4.6.0 user with desc='{value}' saw, and desc was documented as the prefix alias all along. The alias is a plain prefix again: a field renders the bar's data, a dunder walk is refused like any other template, and a literal brace is doubled. The fast formatter never rendered templates and still does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#330 turned
descinto literal text so that a brace in a file name nolonger raised. The gate on the 4.6.0 breaks decided the other way: desc
was documented as the prefix alias all along, so a 4.6.0 user with
desc='{value}'keeps the rendered value.descis a plain prefix again: a field renders the bar's data, adunder or frame walk is refused like any other template, a literal
brace is doubled.
_literal_prefixand the brace escaping in_init_prefixare gone.Checks: pytest 3.10 with coverage 1807 passed, 100%, ruff and pyright
clean. The #330 compatibility probes for desc now print the 4.6.0
values again (
desc='{value}'renders10:,desc='{'raisesValueError as in 4.6.0).