Skip to content

Comments

20260221-configure-all-crypto-fpecc#9814

Merged
kaleb-himes merged 1 commit intowolfSSL:masterfrom
douzzer:20260221-configure-all-crypto-fpecc
Feb 21, 2026
Merged

20260221-configure-all-crypto-fpecc#9814
kaleb-himes merged 1 commit intowolfSSL:masterfrom
douzzer:20260221-configure-all-crypto-fpecc

Conversation

@douzzer
Copy link
Contributor

@douzzer douzzer commented Feb 21, 2026

configure.ac: restore fpecc to enable-all-crypto, accidentally removed in f376ae2.

tested with

wolfssl-multi-test.sh ...
'.*cust-kernel.*'

History on this:
Before #9800, fpecc was excluded from ENABLED_LINUXKM_PIE builds, with this note:

    # the compiler optimizer generates a weird out-of-bounds bss reference for
    # find_hole() in the FP_ECC implementation.
    if test "$ENABLED_LINUXKM_PIE" != yes
    then
        test "$enable_fpecc" = "" && test "$enable_ecc" != "no" && enable_fpecc=yes

After #9800, the ELF addend is compensated in each relocation, so all reconstructed symbol offsets are strictly in-bounds, and fpecc is safe in linuxkm-pie builds.

Meanwhile, the complete removal of fpecc from all-crypto was purely an editing error.

Copy link
Contributor

@kaleb-himes kaleb-himes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to get rid of --enable-all-crypto as a default setting (not good for FIPS customer to have that on) but also not ideal to lose the optimizations that come with fpecc. Thanks @douzzer

@kaleb-himes kaleb-himes merged commit f60beb6 into wolfSSL:master Feb 21, 2026
410 of 411 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants