Skip to content

Ensure length is at least ID_LEN in SetTicket. #9782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kareem-wolfssl wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Ensure length is at least ID_LEN in SetTicket. #9782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/internal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34824,6 +34824,8 @@ int SendCertificateVerify(WOLFSSL* ssl)
#ifdef HAVE_SESSION_TICKET
int SetTicket(WOLFSSL* ssl, const byte* ticket, word32 length)
{
word32 sessIdLen = (length >= ID_LEN) ? ID_LEN : length;

if (!HaveUniqueSessionObj(ssl))
return MEMORY_ERROR;

Expand Down Expand Up @@ -34856,15 +34858,17 @@ int SetTicket(WOLFSSL* ssl, const byte* ticket, word32 length)
ssl->options.haveSessionId = 1;
#ifdef WOLFSSL_TLS13
if (ssl->options.tls1_3) {
XMEMSET(ssl->session->sessionID, 0, ID_LEN);
XMEMCPY(ssl->session->sessionID,
ssl->session->ticket + length - ID_LEN, ID_LEN);
ssl->session->ticket + length - sessIdLen, sessIdLen);
ssl->session->sessionIDSz = ID_LEN;
}
else
#endif
{
XMEMSET(ssl->arrays->sessionID, 0, ID_LEN);
XMEMCPY(ssl->arrays->sessionID,
ssl->session->ticket + length - ID_LEN, ID_LEN);
ssl->session->ticket + length - sessIdLen, sessIdLen);
ssl->arrays->sessionIDSz = ID_LEN;
}
}
Expand Down
Loading