Conversation
|
Jenkins retest this please: "RequestAbortedException" |
dgarske
force-pushed
the
stm32_hmac
branch
2 times, most recently
from
fd112e1 to
0919f82
Compare
|
Jenkins retest this please: "PRB-linuxkm.txt_0" -> "FAIL scripts/unit.test" |
|
Jenkins retest this please "Generic Config" "AgentOfflineException" |
|
Jenkins retest this please: PRG-long-runtime_0 "FAIL scripts/unit.test" "wolfSSL error: tcp connect failed: Connection refused" |
There was a problem hiding this comment.
Pull request overview
This pull request adds support for STM32 HMAC hardware acceleration, complementing the existing STM32 HASH hardware support. The implementation allows wolfSSL to leverage the STM32 HASH peripheral's HMAC mode for accelerated HMAC operations on supported STM32 microcontrollers (such as STM32H753 and STM32H563 mentioned in the PR description).
Changes:
- Adds conditional compilation support for STM32 HMAC via
STM32_HMACmacro with disable optionNO_STM32_HMAC - Implements hardware-accelerated HMAC functions that interface with STM32 HASH peripheral in HMAC mode
- Integrates STM32 HMAC acceleration into wolfSSL's HMAC API with transparent fallback to software implementation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| wolfssl/wolfcrypt/settings.h | Adds conditional definition of STM32_HMAC macro when NO_STM32_HMAC is not defined |
| wolfssl/wolfcrypt/port/st/stm32.h | Declares HMAC hardware API functions and adds HASH_ALGOMODE_HMAC macro compatibility |
| wolfssl/wolfcrypt/hmac.h | Extends Hmac structure with STM32-specific context and cached algorithm parameters |
| wolfcrypt/src/port/st/stm32.c | Implements STM32 HMAC hardware functions including SetKey, Update (macro), and Final operations |
| wolfcrypt/src/hmac.c | Integrates STM32 HMAC hardware path into wc_HmacSetKey, wc_HmacUpdate, and wc_HmacFinal |
| .wolfssl_known_macro_extras | Adds HASH_AlgoMode_HMAC and NO_STM32_HMAC to known macro list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@dgarske when it is ready, I'm happy to test on an MP1 too (which I think should support this) |
2 participants
Description
Support for STM32 HMAC hardware
Testing
Not tested on hardware yet. Plan to test on STM32H753 then STM32H563.
Checklist