Skip to content

Fix custom RNG initialization cleanup - #11504

Merged
dgarske merged 1 commit into
wolfSSL:masterfrom
aidangarske:fix-custom-rng-init-cleanup
Sep 19, 2026
Merged

dgarske merged 1 commit into
wolfSSL:masterfrom
aidangarske:fix-custom-rng-init-cleanup

Conversation

@aidangarske

@aidangarske aidangarske commented Sep 18, 2026

Copy link
Copy Markdown
Member
  • Guard DRBG failure cleanup with the same feature conditions used for its state.
  • Fix CUSTOM_RAND_GENERATE_BLOCK plus HAVE_HASHDRBG builds, including wolfTPM fwTPM STM32.
  • Add an OS check configuration covering the regressed macro combination.
  • Confirm the regression test fails on master and passes with the fix.
  • Verify the wolfTPM preset and full STM32 fwTPM build and emulator self-test.
  • failure here https://github.com/wolfSSL/wolfTPM/actions/runs/35388773468/job/105756686048?pr=602

Copilot AI lite review requested due to automatic review settings September 18, 2026 21:31
@aidangarske aidangarske added the For This Release Release version 5.9.4 label Sep 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved blocking issues were identified.

Pull request overview

Fixes custom RNG failure cleanup when combined with Hash DRBG and adds regression build coverage.

Changes:

  • Aligns DRBG cleanup guards with initialization conditions.
  • Adds Linux OS-check coverage for the affected configuration.
File summaries
File Description
wolfcrypt/src/random.c Guards DRBG failure cleanup consistently.
.github/configs/os-check-linux.json Adds regression build coverage.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dgarske
dgarske merged commit 683aa40 into wolfSSL:master Sep 19, 2026
403 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants