Skip to content

Testing: Fix HMAC unit test issue #11492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
padelsbach wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

Testing: Fix HMAC unit test issue #11492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/api/test_tls_bounds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,11 +822,14 @@ int test_TLS_hmac_bounds(void)
(word32)(WOLFSSL_MAX_32BIT - 32), 0, application_data, 1,
PEER_ORDER), WC_NO_ERR_TRACE(BUFFER_E));

#ifdef WOLFSSL_TEST_STATIC_BUILD
#if defined(WOLFSSL_TEST_STATIC_BUILD) && !defined(WOLFSSL_NO_HASH_RAW) && \
!defined(HAVE_FIPS) && !defined(HAVE_SELFTEST)
/* Hmac_UpdateFinal_CT()'s own "macLen <= 0" guard: force hash_size
* to 0 for this call only. wc_HmacSetKey() accepts a zero-length
* key (RFC 2104 permits an empty key), so ret stays 0 and this
* still reaches the constant-time path with macLen == 0.
* still reaches the constant-time path with macLen == 0. The
* build conditions match TLS_hmac()'s own: the other path,
* Hmac_UpdateFinal(), takes no macLen and has no such guard.
*
* The guard's other half, "macLen > sizeof(hmac->innerHash)"
* (innerHash is WC_MAX_DIGEST_SIZE bytes), is excluded: macLen is
Expand Down
Loading