Pkcs7 enforce gcm/ccm tag length - #11490
Open
kaleb-himes wants to merge 3 commits into
Open
kaleb-himes wants to merge 3 commits into
kaleb-himes wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PKCS7 AuthEnvelopedData decoding now enforces the ICV sizes RFC 5084 actually permits: 12 to 16 bytes for AES-GCM (section 3.2), and even sizes of 8 bytes or more for AES-CCM (section 3.1 plus the SP 800-38C Appendix B.2 floor), so a bundle cannot dictate a shorter tag than the standard allows even in builds that relax WOLFSSL_MIN_AUTH_TAG_SZ. It also restores the cipher OID when the streaming decoder re-enters at the tag state, without which the size check was silently skipped on chunked input.
Followup of the fixes for zd#22449 (#11478)
Testing
How it was tested
Checklist