Rust wrapper: mldsa: fix cfg detection for public and private build options - #11486
Open
holtrop-wolfssl wants to merge 1 commit into
Open
holtrop-wolfssl wants to merge 1 commit into
holtrop-wolfssl wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Combined import and export methods still need public-API cfg gates to avoid unresolved symbols in private-only builds.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request fixes Rust ML-DSA conditional compilation for separate wolfCrypt public and private build options.
Changes:
- Detects individual ML-DSA API availability.
- Applies feature-specific cfg gates to wrapper methods and tests.
- Updates documentation examples and test conditions.
File summaries
| File | Summary |
|---|---|
wrapper/rust/wolfssl-wolfcrypt/tests/test_mldsa.rs |
Aligns tests with available ML-DSA features. |
wrapper/rust/wolfssl-wolfcrypt/src/mldsa.rs |
Gates wrapper methods and examples by API availability. |
wrapper/rust/wolfssl-wolfcrypt/build.rs |
Detects individual ML-DSA API symbols. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ptions Fixes F-13035.
holtrop-wolfssl
force-pushed
the
f-13035
branch
from
September 17, 2026 14:37
b8f8568 to
18396b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rust wrapper: mldsa: fix cfg detection for public and private build options
Fixes F-13035.
Testing
How did you test?
Checklist