Rust wrapper: fix ed25519/ed448 Keypair possibly panicking without public component - #11485
Open
holtrop-wolfssl wants to merge 1 commit into
Open
holtrop-wolfssl wants to merge 1 commit into
holtrop-wolfssl wants to merge 1 commit into
Conversation
holtrop-wolfssl
force-pushed
the
f-11271
branch
from
September 17, 2026 13:48
f0be387 to
9d91b53
Compare
holtrop-wolfssl
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Reject public-only Ed25519 and Ed448 keys as signing keys and add regression coverage.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR replaces panic-prone Ed25519/Ed448 Keypair implementations with SigningKey wrappers that cache public keys.
Changes:
- Adds
SigningKeyconstructors and trait implementations. - Updates signing and incomplete-key tests.
- Documents the breaking API change.
File summaries
| File | Summary |
|---|---|
wrapper/rust/wolfssl-wolfcrypt/tests/test_ed448.rs |
Updates Ed448 signing-key tests. |
wrapper/rust/wolfssl-wolfcrypt/tests/test_ed25519.rs |
Updates Ed25519 signing-key tests. |
wrapper/rust/wolfssl-wolfcrypt/src/ed448.rs |
Adds the Ed448 signing-key wrapper; public-only keys must be rejected before caching. |
wrapper/rust/wolfssl-wolfcrypt/src/ed25519.rs |
Adds the Ed25519 signing-key wrapper; public-only keys must be rejected before caching. |
wrapper/rust/wolfssl-wolfcrypt/CHANGELOG.md |
Documents the API change and fix. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…blic component Fixes F-11271, F-11272.
holtrop-wolfssl
force-pushed
the
f-11271
branch
from
September 17, 2026 14:33
9d91b53 to
420ef0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rust wrapper: fix ed25519/ed448 Keypair possibly panicking without public component
Fixes F-11271, F-11272.
Testing
How did you test?
Checklist