Rust wrapper: Add ChaCha20Poly1305::finalize_verify()#10933
Open
holtrop-wolfssl wants to merge 1 commit into
Open
Rust wrapper: Add ChaCha20Poly1305::finalize_verify()#10933holtrop-wolfssl wants to merge 1 commit into
holtrop-wolfssl wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a safer/clearer decryption-finalization API to the Rust wolfCrypt ChaCha20-Poly1305 wrapper by introducing ChaCha20Poly1305::finalize_verify(), along with a new unit test and a changelog entry.
Changes:
- Add
ChaCha20Poly1305::finalize_verify()that finalizes and checks the expected authentication tag viawc_ChaCha20Poly1305_CheckTag. - Update
finalize()docs to steer decrypt users towardfinalize_verify()for tag checking. - Add a new Rust test covering success verification and tag-tamper failure; update CHANGELOG.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wrapper/rust/wolfssl-wolfcrypt/src/chacha20_poly1305.rs | Adds finalize_verify() and updates finalize() documentation to clarify decryption tag handling. |
| wrapper/rust/wolfssl-wolfcrypt/tests/test_chacha20_poly1305.rs | Adds a unit test for finalize_verify() (success path + tampered-tag failure). |
| wrapper/rust/wolfssl-wolfcrypt/CHANGELOG.md | Documents the new API as an unreleased feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rust wrapper: Add ChaCha20Poly1305::finalize_verify()
Fixes F-6445
Testing
How did you test?
Checklist