ssl.c: Move code out and some fixes#10926
Open
SparkiDev wants to merge 1 commit into
Open
Conversation
SparkiDev
force-pushed
the
extract_funcs_ssl_2
branch
from
27ab328 to
49f9adb
Compare
|
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10926
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
SparkiDev
force-pushed
the
extract_funcs_ssl_2
branch
from
49f9adb to
0b2e533
Compare
SparkiDev
commented
Jul 16, 2026
SparkiDev
commented
Jul 16, 2026
SparkiDev
commented
Jul 16, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10926
Scan targets checked: wolfcrypt-rs-bugs, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Contributor
Author
|
Jenkins: retest this please FIPS-ready FAILED |
ssl_api_hs.c: Handhshake code ssl_api_rw.c: Reading and writing ssl_err.c: wolfSSL_ERR API ssl_asn1.c: Moved wolfSSL_OBJ API in. Move nid2oid/oid2nid in. ssl_crypt.c: Moved in wolfSSL_RAND API. ssl_api_cert.c, ssl_api_pk.c, ssl_api_dtls.c, ssl_api_crl_osp.c: Added more functions that were clearly in those areas. Fixed nid2oid/oid2nid to use wolfssl_object_info[]. wolfssl_object_info has calculated start and ends of groups for faster lookup. Re-ordered the list within groups for faster lookup. Removed duplicate OID row - WC_NID_userId, WC_NID_userId. Added entries that were only in nid2oidi/oid2nid: - ED25510, Ed448, CSR entries AddSession was declared before HAVE_GLOBAL_RNG was defined - moved global RNG code.
SparkiDev
force-pushed
the
extract_funcs_ssl_2
branch
from
0b2e533 to
a3babcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ssl_api_hs.c: Handhshake code
ssl_api_rw.c: Reading and writing
ssl_err.c: wolfSSL_ERR API
ssl_asn1.c: Moved wolfSSL_OBJ API in. Move nid2oid/oid2nid in. ssl_crypt.c: Moved in wolfSSL_RAND API.
ssl_api_cert.c, ssl_api_pk.c, ssl_api_dtls.c, ssl_api_crl_osp.c:
Added more functions that were clearly in those areas.
Fixed nid2oid/oid2nid to use wolfssl_object_info[]. wolfssl_object_info has calculated start and ends of groups for faster lookup. Re-ordered the list within groups for faster lookup. Removed duplicate OID row - WC_NID_userId, WC_NID_userId. Added entries that were only in nid2oidi/oid2nid:
AddSession was declared before HAVE_GLOBAL_RNG was defined - moved global RNG code.
Testing
Regression tested OpenSSL API