Skip to content

fix: signed-shift UB in ML-DSA gamma1_19 encoder (32-bit path) #10918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkAtwood wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

fix: signed-shift UB in ML-DSA gamma1_19 encoder (32-bit path) #10918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions wolfcrypt/src/wc_mldsa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1829,10 +1829,10 @@ static void mldsa_encode_gamma1_19_bits_c(const sword32* z, byte* s)

/* Step 3. Get 20 bits as a number. */
for (j = 0; j < MLDSA_N; j += 4) {
sword32 z0 = MLDSA_GAMMA1_19 - z[j + 0];
sword32 z1 = MLDSA_GAMMA1_19 - z[j + 1];
sword32 z2 = MLDSA_GAMMA1_19 - z[j + 2];
sword32 z3 = MLDSA_GAMMA1_19 - z[j + 3];
word32 z0 = (word32)(MLDSA_GAMMA1_19 - z[j + 0]);
word32 z1 = (word32)(MLDSA_GAMMA1_19 - z[j + 1]);
word32 z2 = (word32)(MLDSA_GAMMA1_19 - z[j + 2]);
word32 z3 = (word32)(MLDSA_GAMMA1_19 - z[j + 3]);

/* 20 bits per number.
* 4 numbers become 10 bytes. (4 * 20 bits = 10 * 8 bits) */
Expand Down
Loading